AppVeyor configuration #206
Conversation
Fixes haskell#175. Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>
|
I don't have admin access to this repo, so I can't enable AppVeyor. I think @hvr has. |
|
I wonder if it makes sense to support |
|
The patch adding Windows support is not that big, so I think it's fine. |
| createDirectoryIfMissing True (takeDirectory linkLoc) | ||
| linkTarget' <- toAbsoluteFilePath linkTarget | ||
| linkLoc' <- toAbsoluteFilePath linkLoc | ||
| Posix.createSymbolicLink linkTarget' linkLoc' | ||
| #else | ||
| error $ "Cannot create symbolic links on Windows" |
There was a problem hiding this comment.
@23Skidoo this makes symlink-cabal-local-repo command fail. Not that it's useful on Windows, but I'd much happier disabling that codepath cleanly (i.e. disabling the command on windows), and not creating technical debt.
There was a problem hiding this comment.
Fine, but this #ifdef will still be needed.
There was a problem hiding this comment.
by cleanly i mean: #ifdef the whole function, and see what breaks -> disable that with good error message.
There was a problem hiding this comment.
OK, I can look into it tomorrow.
|
BTW, |
|
It would be great if the review concerns from @phadej in line which currently disables |
This includes the changes from #176 (CC @ezyang), rebased against master, and adds in an AppVeyor configuration as requested in #176. I've checked that the AppVeyor configuration works (see https://ci.appveyor.com/project/snoyberg/hackage-security/build/1.0.1), but someone will need to enable AppVeyor for haskell/hackage-security to make this work.