support for prefers-color-scheme
#1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbecich
force-pushed
the
prefers-color-scheme-support
branch
from
96d83d4
to
c86c3a4
Compare
This was referenced Feb 22, 2022
Merged
peterbecich
force-pushed
the
prefers-color-scheme-support
branch
from
80c4f95
to
a02eef6
Compare
peterbecich
force-pushed
the
prefers-color-scheme-support
branch
from
a02eef6
to
b8d43c7
Compare
Swap some of the foreground and background colors
peterbecich
force-pushed
the
prefers-color-scheme-support
branch
3 times, most recently
from
f8c28b9
to
16f1669
Compare
peterbecich
force-pushed
the
prefers-color-scheme-support
branch
from
16f1669
to
f5a17d2
Compare
|
Feedback appreciated I think the default mode is unchanged. Viewing in Firefox: How do I populate the module documentation / function definitions? I should check the function definitions look okay.
|
peterbecich
changed the title
prefers-color-schemeprefers-color-scheme
|
Here is the Paginator |
peterbecich
force-pushed
the
prefers-color-scheme-support
branch
from
c43dfcd
to
ec28b4e
Compare
|
I like the colors and everything is clearly readable. |
|
One thing I've not checked are any function definitions like: because on my local instance of Hackage Server these are unpopulated: Can you tell me how to populate these? |
|
Looks like there is more to do The Haddock exists now It must use a different set of style sheets |
gbaz
added a commit
that referenced
this pull request
Jan 5, 2023
* delete unused GitHub Action; fix CI badge * Fix #1076: separate validators from UI and doctest them (#1077) * Cachix caching for nix-shell GitHub Action (#1081) * Add uploaded_at field in package api (#1080) * package page: Include virtual-modules in module tree (#1085) * Allow hashable-1.4 and text-2.0 (#1089) * Divide sitemap into parts * Add sitemap link for subdirectories * Fix `non-canonical-return` warnings * Bump CI to GHC 9.2.3 and restrict to master branch * Check authorisation (#1111) * Dynamically add css piece * Fix #1105: change order of markdown parsers to allow pipes in lists * Fix #1128, fix #1130 by adding bounds to Cabal-syntax and haddock-library * Bump CI to 9.2.4 and some deps * Force .txt and .text to have UTF-8 MIME charset (#1133) * Upgrade to haddock-library-1.11.0 (#1126) * attempt to speed up GitHub Action for Nix Shell * work with cabal 3.8 * Updated accepted licenses (#1092) * Add dependabot for github workflows * Bump cachix/cachix-action from 10 to 12 * Bump actions/checkout from 2.4.0 to 3.1.0 * Bump cachix/install-nix-action from 17 to 18 * Build with Cabal-3.8 and GHC 9.4 (#1141) * Haskell CI: bump to Ubuntu-22.04, GHC 9.2.5 and 9.4.4 * Allow mtl-2.3 and transformers-0.6 (#1150) * Disable test (#1124) * allow disable tests on client side * add deprecated version warning (#1123) * List maintainers on package page (#1098) * List maintainers on package page * Vendor snowball package (#1116) * Add searchbox metadata (#1115) * Add captcha for user registration (#1099) * remove filtering 00-index for cabal version < 2.0 hack (#1152) * Add lastVersion in listings (#749) (#1140) * rm icu dep instructions, add libgd * Add test log display (#1100) * Add test log * Reverse Dependencies indexed on PackageName (#1082) * Rebased Reverse Dependencies * Add "Quick Jump" to candidate package page (#1122) * Solves #1029 - Adds paging to recent packages and recent revisions (#1055) * support for `prefers-color-scheme` (#1008) * 2x brightness for captions and links in dark color scheme * table dark color scheme * prefers-color-scheme for links, footer, and table-of-contents * paginator css for `prefers-color-scheme` * Maintainer notifications * cleanup partial functions for revdeps, elim use of MonadThrow, MonadCatch * fix tests enablement link Co-authored-by: Peter Becich <peterbecich@gmail.com> Co-authored-by: Andreas Abel <andreas.abel@ifi.lmu.de> Co-authored-by: Hécate Moonlight <Kleidukos@users.noreply.github.com> Co-authored-by: Matthew Pickering <matthewtpickering@gmail.com> Co-authored-by: ˌbodʲɪˈɡrʲim <andrew.lelechenko@gmail.com> Co-authored-by: Alias Qli <2576814881@qq.com> Co-authored-by: Ondřej Kubánek <71923533+kubaneko@users.noreply.github.com> Co-authored-by: Gautier DI FOLCO <gautier.difolco@gmail.com> Co-authored-by: Janus Troelsen <ysangkok@gmail.com> Co-authored-by: Levi Butcher <31522433+LeviButcher@users.noreply.github.com>
|
For the most part people seem really happy about this! However, a comment points out a few missed spots -- quickjump, and also the (new) revdeps feature. A pr to fix these up would be most welcome. https://discourse.haskell.org/t/new-hackage-server-features/2621/28 |
|
oh some of the banners too https://twitter.com/qnikst/status/1611392984700055552 |
|
Whoops, I'll prioritize an opt-in button, will try to get this done today |
|
In my opinion, an opt-out is not so important, compared to just fixing up the maybe three cases discovered so far that need to be handled. Luckily as this is just a CSS change, deploying it will be safe and simple. |
|
Okay, will do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1007
https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme
Some of the foreground and background colors are simply swapped.
hrefcolors should probably be brightened.