Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

night mode fixes for candidate packages and reverse dependencies #1162

Closed
wants to merge 3 commits into from
Closed

night mode fixes for candidate packages and reverse dependencies #1162

wants to merge 3 commits into from

Conversation

peterbecich
Copy link
Member

  • candidate packages
    Screenshot 2023-01-06 at 16-50-05 Checking and uploading candidates Hackage
    Screenshot 2023-01-06 at 17-09-02 2captcha Haskell package for easy integration with the 2captcha API

@peterbecich peterbecich mentioned this pull request Jan 7, 2023
Merged
@peterbecich
Copy link
Member Author

Reverse dependencies; dark and light modes
Screenshot 2023-01-06 at 17-59-54 AesonBson
Screenshot 2023-01-06 at 18-00-16 AesonBson

peterbecich
peterbecich commented Jan 7, 2023
View reviewed changes
datafiles/templates/packagePageAssets.st
@@ -20,7 +20,6 @@

div#modal #content {
border-radius: 8px;
background: #fff;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has to be removed, otherwise it takes precedence over hackage.css

@peterbecich peterbecich changed the title WIP night mode fixes night mode fixes for candidate packages and reverse dependencies Jan 7, 2023
@peterbecich peterbecich marked this pull request as ready for review January 7, 2023 02:33
@peterbecich peterbecich requested a review from gbaz January 7, 2023 02:34
@peterbecich
Copy link
Member Author

peterbecich commented Jan 7, 2023 •
edited

@gbaz , please review

I will fix the quickjump issue separately: #1163

@peterbecich peterbecich mentioned this pull request Jan 7, 2023
Merged
@gbaz
Copy link
Contributor

gbaz commented Jan 7, 2023

I deployed these manually on prod and they look good so far!

@peterbecich
Copy link
Member Author

Thanks!

@peterbecich
Copy link
Member Author

Do you see this transparency here? I need to fix something
https://hackage.haskell.org/package/hint
Screenshot 2023-01-06 at 20-55-59 hint

@peterbecich
Copy link
Member Author

Still trying to repro locally, doesn't appear immediately
Screenshot 2023-01-06 at 21-04-46 BiobaseEnsembl

@gbaz
Copy link
Contributor

gbaz commented Jan 7, 2023

I suspect just stale css. I purged the cache, but you may need a forced-reload.

@peterbecich
Copy link
Member Author

you're correct, looks good now
Screenshot 2023-01-06 at 21-11-14 hint

@peterbecich
Copy link
Member Author

combined with https://github.com/haskell/hackage-server/pull/1163/commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbaz gbaz Awaiting requested review from gbaz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterbecich @gbaz