Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haddock generates Source links to re-exported items without module names (under Nix; possibly in general) #1498

Open
lf- opened this issue Jun 20, 2022 · 3 comments
Labels

Comments

@lf-
Copy link
Contributor

lf- commented Jun 20, 2022

I noticed this in Esqueleto although it is probably reproducible in packages with fewer dependencies.

Reproduction:

$ nix-build '<nixpkgs>' -A haskellPackages.esqueleto.doc
/nix/store/9mh0h5ll38wxwan66r79n7ysfvfsw16v-esqueleto-3.5.5.0-doc
$ firefox result-doc/share/doc/esqueleto-3.5.5.0/html/Database-Esqueleto.html#t:PersistField

Then click the Source link next to PersistField, which has an href property of file:///nix/store/d121c0wdrwsnms2m9s48fbw7104rqmbz-persistent-2.13.3.5-doc/share/doc/persistent-2.13.3.5/html/src, missing a file name. This is significantly more troublesome on Hoogle which doesn't show directory contents.

This is likely a related shape of bug as was fixed in #1482 but it's on the module pages rather than in the hyperlinker itself.

Versions:

dev/nixpkgs2 - [remotes/origin/HEAD] » nix-shell -p haskellPackages.ghc

[nix-shell:~/dev/nixpkgs2]$ ghc --version
The Glorious Glasgow Haskell Compilation System, version 9.0.2

[nix-shell:~/dev/nixpkgs2]$ haddock --version
Haddock version 2.25.1, (c) Simon Marlow 2006
Ported to use the GHC API by David Waern 2006-2008
@Kleidukos
Copy link
Member

I imagine that this is fixed by #1482. Please do re-open if it is not.

@lf-
Copy link
Contributor Author

lf- commented Aug 7, 2023

I believe it was not; I can try reproducing again but I remember filing this after having applied that patch.

(fyi i can't reopen myself for some reason)

@Kleidukos
Copy link
Member

Great, thank you

@Kleidukos Kleidukos reopened this Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants