Create Tabular package #209
Conversation
|
When this MR is merged, #200 would be obsolete. @Ericson2314 @int-index I believe the one thing left here is renaming, and possibly moving, |
|
|
Hmm I'd probably prefer documenting this somewhere in the code. |
|
@knothed That's better! Then I'd say leave where it was in this commit, and then convert to code comments in subsequent commit. |
| @@ -417,18 +417,21 @@ the spontaneous lookaheads in the right form to begin with (ToDo). | |||
| ----------------------------------------------------------------------------- | |||
| Merge lookaheads | |||
|
|
|||
| > -- TODO needs better name | |||
| > type Lr1State = ([Lr1Item], [(Name, Int)]) | |||
There was a problem hiding this comment.
Maybe we should do sth about the todo :D @Ericson2314
|
Could this be merged? I think we won't need #200 anymore after merging this. |
|
Oh sorry I lost track of this. I am fine with |
|
#200 I rebased to just be additional splits and the main part, so I am happy to keep it around for later for when we revisit that sort of stuff :) |
|
I will review by Monday. |
|
I have not reviewed by Monday. Shame on me. But I’m doing it right now. |
|
LGTM. Thank you! |
Create a Tabular package which contains the
Tabularmodule and related stuff like LALR.