Create Frontend package #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Todo: adapt Haskell-CI (note to myself) |
Ericson2314
reviewed
Nov 24, 2021
Ericson2314
reviewed
Nov 24, 2021
Ericson2314
reviewed
Nov 24, 2021
knothed
force-pushed
the
frontend
branch
2 times, most recently
from
11bc4e3
to
877b12d
Compare
Done. Seems to work. |
Ericson2314
approved these changes
Nov 26, 2021
|
I haven’t looked at this as carefully as at the previous patches, but overall this looks good to me. |
|
This diff is indeed simpler to read, so I don't think there is anything we missed. I'll merge it. Thanks again, @knothed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is pretty straightforward, it moves all frontend-specific files into the
happy-frontendpackage.