Get rid of an incomplete pattern match #247
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasabel
reviewed
Jan 31, 2023
| @@ -202,7 +202,7 @@ Extract the string that comes before the module declaration... | |||
| > . table_text | |||
|
|
|||
| > lib_content lib_text | |||
| > = let (pre,_drop_me : post) = break (== "fakeimport DATA") $ lines lib_text | |||
| > = let (pre,post) = break (== "fakeimport DATA") $ lines lib_text | |||
There was a problem hiding this comment.
Should we make such a change? I think it is hurting code comprehensibility more than helping it.
The current formulation makes clear that the _drop_me : post match MUST succeed, even if GHC does not see it.
The new formulation clouds this insight.
So, I am against such a change.
There was a problem hiding this comment.
Yes it would be better to add an explicit pattern match with an error .... It would be even better to try to use NonEmpty.
There was a problem hiding this comment.
NonEmpty is available from base-compat for old GHC versions back to 7.0 (base-4.3), so that would not be a problem for keeping all currently supported GHC versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.