Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Commit

Permalink
Fix UriCaches being leaked
Browse files Browse the repository at this point in the history
This fixes UriCaches from being leaked via GhcModuleCaches.
This is the result of 72 hours at ZuriHac between 3 people and a lot of
time spent in gdb.

Blog post coming soon

Co-Authored-By: Matthew Pickering <matthewtpickering@gmail.com>
Co-Authored-By: Daniel Gröber <dxld@darkboxed.org>
  • Loading branch information
3 people committed Jun 16, 2019
1 parent d679eb5 commit 4d179a9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hie-plugin-api/Haskell/Ide/Engine/PluginsIdeMonads.hs
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,7 @@ withIndefiniteProgress t c f = do
Just wp -> control $ \run -> wp t c (run f)

data IdeState = IdeState
{ moduleCache :: GhcModuleCache
{ moduleCache :: !GhcModuleCache
-- | A queue of requests to be performed once a module is loaded
, requestQueue :: Map.Map FilePath [UriCacheResult -> IdeM ()]
, extensibleState :: !(Map.Map TypeRep Dynamic)
Expand Down

0 comments on commit 4d179a9

Please sign in to comment.