Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

stack install.hs hie-8.4.4 installs ghc-8.6.2 and ghc-8.6.4 compilers as well #1159

Closed
nponeccop opened this issue Apr 4, 2019 · 15 comments
Closed
Labels
build Continuous integration and building
Milestone

Comments

@nponeccop
Copy link
Contributor

And 3 respective snapshots: lts-12.26, lts-13.12, nightly-2018-12-15.

I think that at least one of the 2 "extra" snapshots/ghcs can be eliminated.

@jneira
Copy link
Member

jneira commented Apr 5, 2019

As a side note, stack script does not use .stack/config.yaml so it reinstalls ghc-8.6.2 in the default local-programs-path if you have change it to other location in the config.
Hopefully it seems it is going to honour it: commercialhaskell/stack#3887 (comment)

@nponeccop
Copy link
Contributor Author

@jneira apparently the stack bug is already closed. Can you recheck with stack-git?

@jneira
Copy link
Member

jneira commented Apr 7, 2019

Of course, i've just downloaded the artifacts of build here: https://dev.azure.com/commercialhaskell/stack/_build/results?buildId=1170
and it honours my user config file. 👍

@lukel97 lukel97 added the build Continuous integration and building label Apr 8, 2019
@fendor
Copy link
Collaborator

fendor commented Apr 9, 2019

Yes, normally only one additional snapshot should be required.
The PR #1168 may address this problem.

@samuelpilz
Copy link
Contributor

This is fixed in #1168

@nponeccop
Copy link
Contributor Author

It isn't merged as of April 20

@fendor
Copy link
Collaborator

fendor commented Apr 20, 2019

Should be fixed now, please check!

@fendor fendor closed this as completed Apr 20, 2019
@lukel97
Copy link
Collaborator

lukel97 commented Apr 21, 2019

On a related note, is it possible to use
system-ghc: true in shake.yaml to avoid stack having to download another snapshot/compiler? Assuming that install.hs is backwards compatible with other versions of ghc?

@fendor
Copy link
Collaborator

fendor commented Apr 21, 2019

Possibly yes. @power-fungus?

@samuelpilz
Copy link
Contributor

samuelpilz commented Apr 21, 2019

I will test that. What happens if there is no system-ghc?

@fendor
Copy link
Collaborator

fendor commented Apr 21, 2019

Afaik, it errros out.

@nponeccop
Copy link
Contributor Author

Should be fixed now, please check!

works for me

@alanz alanz added this to the 2019-04 milestone May 4, 2019
@Avi-D-coder
Copy link
Collaborator

Can the shake resolver be bumped to nightly-2019-04-30 so that it's in sync with stack.yaml?

Have the issues with 8.6.3 on windows been fixed for 8.6.5?

@fendor
Copy link
Collaborator

fendor commented May 22, 2019

The issue of 8.6.3 ist fixed on 8.6.4 already. At least, I can build hie 8.6.4 on windows.

Regarding bumping shake-resolver, in general, there is no problem with that, in general. We can open a new issue for that.

@fendor
Copy link
Collaborator

fendor commented May 22, 2019

I opened an issue for bumping the shake resolver #1266.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build Continuous integration and building
Projects
None yet
Development

No branches or pull requests

7 participants