Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Make sure the end of formatted text is properly indicated #1189

Merged
merged 1 commit into from Apr 22, 2019
Merged

Make sure the end of formatted text is properly indicated #1189

merged 1 commit into from Apr 22, 2019

Conversation

alanz
Copy link
Collaborator

@alanz alanz commented Apr 22, 2019

Closes #1188

@alanz alanz merged commit 7bf8f7e into haskell:master Apr 22, 2019
@Hogeyama
Copy link
Contributor

Hi! The changes on this line and this line are unnecessary because newlines are surely inserted by T.unlines, aren't they? It now outputs a redundant empty line like this:

```haskell
> const 42 "hello"
42

```

@alanz
Copy link
Collaborator Author

alanz commented Apr 23, 2019

@Hogeyama you are correct, it is only actually markupCodeBlock that was faulty. I will revert that part.

alanz added a commit to alanz/haskell-ide-engine that referenced this pull request Apr 23, 2019
@alanz
Undo unnecessary changes from haskell#1189
20dc61c 
As per @Hogeyama  comment at
haskell#1189 (comment)
@alanz alanz mentioned this pull request Apr 23, 2019
Merged
fendor added a commit that referenced this pull request Apr 25, 2019
@fendor
Merge pull request #1199 from alanz/fix-haddock-end-quotes
57b7319 
Undo unnecessary changes from #1189
@infinisil infinisil mentioned this pull request May 4, 2019
Merged
@alanz alanz added this to the 2019-04 milestone May 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fendor fendor fendor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2019-04
Development

Successfully merging this pull request may close these issues.

New documentation fails for bimap
3 participants
@alanz @Hogeyama @fendor