Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Add stack-install-cabal target and confirmation messages #1405

Merged
merged 2 commits into from Oct 8, 2019
Merged

Add stack-install-cabal target and confirmation messages #1405

merged 2 commits into from Oct 8, 2019

Conversation

jneira
Copy link
Member

@jneira jneira commented Oct 8, 2019

  • For stack users that want to install auto cabal with the required minimum version to work with hie
  • As bonus, i've added some confirmation messages when installing cabal and when installing hie using cabal

@jneira jneira added the build Continuous integration and building label Oct 8, 2019
@jneira jneira requested a review from fendor October 8, 2019 10:29
@jneira jneira mentioned this pull request Oct 8, 2019
Closed
@jneira
Copy link
Member Author

jneira commented Oct 8, 2019

The pr should fix the behaviour described in haskell/vscode-haskell#131 (comment)

@fendor fendor requested a review from samuelpilz October 8, 2019 13:29
samuelpilz
samuelpilz approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@samuelpilz samuelpilz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This seems useful

@samuelpilz
Copy link
Contributor

Btw, is cabal still reqired for stack projects when using the hie bios?
Cc @fendor

@fendor
Copy link
Collaborator

fendor commented Oct 8, 2019

I dont think so. Stack should depend only on stack.

@fendor
Copy link
Collaborator

fendor commented Oct 8, 2019 •
edited

However, stack cradle depends on ghc iirc. @power-fungus

fendor
fendor suggested changes Oct 8, 2019
View reviewed changes
install/src/HieInstall.hs Show resolved Hide resolved
@fendor fendor self-requested a review October 8, 2019 21:20
@fendor fendor merged commit 25678ff into haskell:master Oct 8, 2019
@jneira jneira deleted the stack-install-cabal branch October 9, 2019 12:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samuelpilz samuelpilz samuelpilz approved these changes

@fendor fendor fendor approved these changes

Assignees
No one assigned
Labels
build Continuous integration and building
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jneira @samuelpilz @fendor