add comments and use custom newness check in ghcide too

haskell · Oct 24, 2021 · 7dfc9eb · 7dfc9eb
1 parent 49f2f6a
commit 7dfc9eb
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/ghcide/src/Development/IDE/Core/RuleTypes.hs b/ghcide/src/Development/IDE/Core/RuleTypes.hs
@@ -49,6 +49,9 @@ data LinkableType = ObjectLinkable | BCOLinkable
 instance Hashable LinkableType
 instance NFData   LinkableType
 
+-- | Encode the linkable into an ordered bytestring.
+--   This is used to drive an ordered "newness" predicate in the
+--   'NeedsCompilation' build rule.
 encodeLinkableType :: Maybe LinkableType -> ByteString
 encodeLinkableType Nothing               = "0"
 encodeLinkableType (Just BCOLinkable)    = "1"

diff --git a/ghcide/src/Development/IDE/Core/Rules.hs b/ghcide/src/Development/IDE/Core/Rules.hs
@@ -1080,7 +1080,13 @@ mainRule = do
     getClientSettingsRule
     getHieAstsRule
     getBindingsRule
-    defineEarlyCutoff $ RuleNoDiagnostics $ \NeedsCompilation file ->
+    -- This rule uses a custom newness check that relies on the encoding
+    --  produced by 'encodeLinkable'. This works as follows:
+    --   * <previous> -> <new>
+    --   * ObjectLinkable -> BCOLinkable : the prev linkable can be reused,  signal "no change"
+    --   * Object/BCO -> NoLinkable      : the prev linkable can be ignored, signal "no change"
+    --   * otherwise                     : the prev linkable cannot be reused, signal "value has changed"
+    defineEarlyCutoff $ RuleWithCustomNewnessCheck (<=) $ \NeedsCompilation file ->
         needsCompilationRule file
     generateCoreRule
     getImportMapRule