-
-
Notifications
You must be signed in to change notification settings - Fork 347
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Attempt to use Fourmolu 0.5 on GHC 8.10.7
- Loading branch information
Showing
3 changed files
with
60 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf5cbec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cf5cbec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebasing on #2655 makes no difference.
cf5cbec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It means that
formulu
wantsghc-lib-parser ==8.10.7.20210828
.You can try to either:
Unfortunately, all of that is a nightmare because most of our dependencies depends on different version of ghc-lib-parser, which is not what nix provides by default. But it can be overriden.
I'm having a look at it right now.
cf5cbec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only overrides
Cabal
andghc-lib-parser
forfourmolu
. Works for me.cf5cbec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @guibou! That's just what I needed.
In what sense? Fourmolu 0.5 requires 9.2. And with
stylish-haskell
disabled, all of HLS' dependencies should build with 9.2.cf5cbec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was a mistake. The error was not
fourmolu
complaining about wantingghc-lib-parser 8.10.7
, but another package. Sorry ;)cf5cbec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I spoke too soon. I'm getting some weird errors now. Are the shells just broken on
aarch64-darwin
?Spoiler warning
cf5cbec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's possible. Please have a look at #2655 that I'm attempting to merge (and which indeed fails with "advanced" nix shell). In that MR, I'm introducing now development shells where haskell dependencies are not built by nix anymore, hence it should work more regularly.
Haskell deps are still built by nix when building haskell-language-server nix derivation, but there is less to build (because it won't integrate the dependencies for testing and benchmarking).