Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split code action for disabling warnings into HLS's pragma plugin #1413

Closed
berberman opened this issue Feb 20, 2021 · 0 comments · Fixed by #1417
Closed

Split code action for disabling warnings into HLS's pragma plugin #1413

berberman opened this issue Feb 20, 2021 · 0 comments · Fixed by #1417
Assignees

Comments

@berberman
Copy link
Collaborator

Work done in #1235 is basically inserting pragmas. Now we have already organized pragma related code in a standalone HLS plugin, including adding pragmas and pragmas completion, thus I think this code action should be moved to pragma plugin as well. By doing this, #1340 can use the logic inserting pragmas shared from #1235.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants