Add pragma after she-bang

[ishmum123]

Draft PR for #555

[ishmum123]

Hi @Ailrun, sorry for the late reply. I have been trying to get parsedModule required for the endOfModuleHeader but I keep running into this-

Exception: BadDependency "GetParsedModuleWithComments"

Any Ideas?

[Ailrun]

What do you mean by "trying to get"? The code to retrieve ParsedModule was already there, right?

[ishmum123]

Yes, the value of pm is Nothing from the printed output I got

[Ailrun]

You mean even before your code? Your code does not change anything related with pm loading, so I don't get what is the problem....

[ishmum123]

As far as I could check that happened before my code as well. Also, I couldn't figure out what problems a Nothing module would have seems like -

genPragma mDynflags target = [ r | r <- findPragma target, rnotElemdisabled] where disabled | Just dynFlags <- mDynflags -- GHC does not export 'OnOff', so we have to view it as string = [ e | Just e <- T.stripPrefix "Off " . T.pack . prettyPrint <$> extensions dynFlags] | otherwise -- When the module failed to parse, we don't have access to its -- dynFlags. In that case, simply don't disable any pragmas. = []

this is the only place Maybe gets checked and not disabling any pragmas would not have been noticed till now. I am really sorry for the noob questions

[Ailrun]

As I believe it surely works and disables some, so I just checked, and it properly disables No- pragmas. I think that problem is more like an issue occurring with some specific settings.

P.S. There's nothing wrong with asking questions :) If my answers sound too hostile, I'm sorry. It's probably because I'm too busy right now...

[ishmum123]

@Ailrun this is most of what I could conjure up. In theory, if pm is not Nothing it should work. Would be grateful if you could check when you are free

[ishmum123]

@Ailrun what about now? Also, if this is done, please suggest me some other issues...

[Ailrun]

The intention is when we have

#! /usr/bin/env nix-shell
#! nix-shell --pure -i runghc -p "haskellPackages.ghcWithPackages (hp: with hp; [ turtle ])"

{-# LANGUAGE ScopedTypeVariables #-}
module AfterShebang where

foo :: forall a. a -> a
foo = id @a

we get

#! /usr/bin/env nix-shell
#! nix-shell --pure -i runghc -p "haskellPackages.ghcWithPackages (hp: with hp; [ turtle ])"

{-# LANGUAGE ScopedTypeVariables #-}
{-# LANGUAGE TypeApplications #-}
module AfterShebang where

foo :: forall a. a -> a
foo = id @a

right? Then I have one question: Why do we need to check contents? I notice that somh itself is good enough...
Do you have any other cases that are not covered by somh?

[Ailrun]

BTW, this is why the tests fail. Current code actually gives

{-# LANGUAGE TypeApplications #-}
#! /usr/bin/env nix-shell
#! nix-shell --pure -i runghc -p "haskellPackages.ghcWithPackages (hp: with hp; [ turtle ])"

{-# LANGUAGE ScopedTypeVariables #-}
module AfterShebang where

foo :: forall a. a -> a
foo = id @a

as it checks from the first line.

[ishmum123]

I could not figure out the case for contents as well. I mostly copied from CodeAction.hs -> endOfModuleHeader

[ishmum123]

I used the somh only but can't figure out why it still adds pragma to the first line. Sorry about that

[Ailrun]

Does it work in your local machine? GetParsedModuleWithComments errors probably come frome other tests, so could you check addPragma tests?

[ishmum123]

Thank you very much for being so patient

[ishmum123]

@Ailrun please let me know if I can help in anything

[Ailrun]

Sorry, I'm really busy for this week or two... maybe @jneira can also help? I'm not sure.

[jneira]

will try

[ishmum123]

Thanks @jneira ... means a lot

[jneira]

The pr needs a rebase, i've try to do it here: ishmum123/haskell-language-server@bug-fix/pragma-before-shebang...jneira:pr1340
Not sure if it is correct though, it only compiles

[jneira]

@ishmum123 thanks for the patience and your work, here and indirectly in #1417

[ishmum123]

@jneira my pleasure... would be grateful if you could point to another issue

[jneira]

@ishmum123 nice! there are some issues labeled with good first issue (well they are good as second or third too 😄 )

For example one that should be quite straightforward would be #1341