Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monthly release? #272

Closed
alanz opened this issue Aug 2, 2020 · 12 comments
Closed

monthly release? #272

alanz opened this issue Aug 2, 2020 · 12 comments
Labels
status: in discussion Not actionable, because discussion is still ongoing or there's no decision yet

Comments

@alanz
Copy link
Collaborator

alanz commented Aug 2, 2020

We did a release 5 days ago.

According to our "normal" schedule we should be pushing out 0.3 around now.

Should we?

Pros - gets us back on the cadence
Cons - we just did a release

cc @bubba @fendor @jneira @pepeiborra @wz1000

@alanz alanz added the status: in discussion Not actionable, because discussion is still ongoing or there's no decision yet label Aug 2, 2020
@Ailrun
Copy link
Member

Ailrun commented Aug 2, 2020

I prefer not to release now, as there were only few updates that really matter after the 0.2.2... Most of commits are about repository management or so.

@pepeiborra
Copy link
Collaborator

What is the normal schedule? A major release every 2 weeks?

What are the steps to make a release? How much automation is there?

If we can merge and release the retrie plugin, that would be pretty cool.

@alanz
Copy link
Collaborator Author

alanz commented Aug 2, 2020

@pepeiborra The normal schedule with hie was once a month, around this time of the month. The logic is that a regular cadence makes more sense than some kind of big-bang release, as there is continuous improvement over the month.

@Anrock
Copy link
Contributor

Anrock commented Aug 2, 2020

How about just skipping this one and calling the previous one as "a lil bit too early montly-release"?

@fendor
Copy link
Collaborator

fendor commented Aug 3, 2020

We should probably think about more automation in the release process.

Do we want to keep these minor version releases? Maybe once in the middle of the month?

Personally, I dont feel strongly about this monthly release, keeping the cadence is fine by me, we have some bug fixes for ormolu right?

@alanz
Copy link
Collaborator Author

alanz commented Aug 3, 2020

Do we want to keep these minor version releases? Maybe once in the middle of the month?

I would say we should not have them as a regular feature. This month we needed them to trigger and debug the static binary download porcess.

Every release we do pushes a burden to the downstream people, in terms of packaging and the like. This is why I like to keep a simple cadence, people can align their processes to ours.

@lukel97
Copy link
Collaborator

lukel97 commented Aug 3, 2020

Now that the retrie plugin is in, I think we have enough features to warrant a release

@alanz
Copy link
Collaborator Author

alanz commented Aug 4, 2020

Retrie is in, and the new hls-3 branch. So I reckon a new release

@pepeiborra are there any retrie follow-ups that need to go in, within a day or so?

@pepeiborra
Copy link
Collaborator

I'm not working on any further retrie changes at the moment.

@lukel97
Copy link
Collaborator

lukel97 commented Aug 6, 2020

@alanz if possible I'd like to get #289 and the fix for #221 in for this release, hopefully I should have the latter done today

@alanz
Copy link
Collaborator Author

alanz commented Aug 6, 2020

@bubba that is fine.

And if you have the time/are able, would you like to do the release too? It is not clear how it ties in to the vscode extension, better for you to shepherd it until we have a solid howto/automation.

@lukel97
Copy link
Collaborator

lukel97 commented Aug 10, 2020

0.3.0 is released now

@lukel97 lukel97 closed this as completed Aug 10, 2020
pepeiborra pushed a commit that referenced this issue Dec 27, 2020
Shake 0.18.4 started exporting Info from this module which clashes
with the one from haskell-lsp. Fixes #271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: in discussion Not actionable, because discussion is still ongoing or there's no decision yet
Projects
None yet
Development

No branches or pull requests

6 participants