Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for GHC-8.10.3 #311

Closed
mouse07410 opened this issue Aug 11, 2020 · 17 comments
Closed

Support for GHC-8.10.3 #311

mouse07410 opened this issue Aug 11, 2020 · 17 comments
Labels
status: blocked Not actionable, because blocked by upstream/GHC etc. type: enhancement New feature or request

Comments

@mouse07410
Copy link

Since 8.10.2 turned out to be a short-term update. and 8.10.3 is about to be released and become "it", HLS should support it. ;-)

@Ailrun Ailrun added the type: enhancement New feature or request label Aug 11, 2020
@mouse07410
Copy link
Author

Out of curiosity - do you know if GHC-8.10.3 is coming, and if so - roughly when?

@jneira jneira added the status: blocked Not actionable, because blocked by upstream/GHC etc. label Nov 9, 2020
@jneira
Copy link
Member

jneira commented Nov 9, 2020

it still has not been released

@domenkozar
Copy link
Contributor

would be great to also support non-moving GC once it lands

@pepeiborra
Copy link
Collaborator

What needs to be done to support the non-moving GC? Do you want to enable it by default?

@domenkozar
Copy link
Contributor

Probably only a flag to enable it if compiled with GHC 8.10.3+ and some testing that it works.

@alanz
Copy link
Collaborator

alanz commented Dec 23, 2020

What needs to be done, now it has been released?

@jneira
Copy link
Member

jneira commented Dec 23, 2020

wait for secondary releases in package managers used by ci, chocolatey f.e. for Windows
maybe we could cut a stack.yaml using it right now

@alanz
Copy link
Collaborator

alanz commented Dec 23, 2020

Ok. Can we do a release that installs for non-windows (e.g. ghcup installed), and then follow up with the rest?

Not sure how long the wait will be.

@jneira
Copy link
Member

jneira commented Dec 23, 2020

yeah, GitHub macos uses ghcup, Linux hvr ppa and Windows choco, circle ci stack (so it needs only a working stack.yaml)
will check them

@jneira
Copy link
Member

jneira commented Dec 23, 2020

I am preparing the support here: https://github.com/jneira/haskell-language-server/tree/ghc-8.10.3 but no ci provider is ready yet nor stack. You can set compiler: ghc-8.10.3 but you have to install it manually.

@berberman
Copy link
Collaborator

@jneira Thanks, I tried your ghc-8.10.3 branch, and it works :-)
BTW, should ghc-lib-8.10.3.20201220 be allowed?

@jneira
Copy link
Member

jneira commented Dec 25, 2020

BTW, should ghc-lib-8.10.3.20201220 be allowed?

yeah, we have to at least, try it out, thanks to note it

ghc-8.10.3 is already in chocolatey, so we only have to wait for support in github actions and stack.

@jneira
Copy link
Member

jneira commented Dec 25, 2020

Issue in github virtual envs: actions/runner-images#2353

@jneira
Copy link
Member

jneira commented Dec 25, 2020

Issue in haskell docker images asking for support for ghc-8.10.3: haskell/docker-haskell#31

pepeiborra pushed a commit that referenced this issue Dec 27, 2020
* Tests for issue 310 (misleading hover on inner signature)

The most important pair of tests here is the "inner signature" pair. The others
serve mainly to document, compare and contrast what is happening in related
situations.

In summary, hover and gotoDef

+ on inner signatures: give type and location information for the outer
  definition; this is misleading,

+ on outer signatures: give no information at all,

+ on inner definitions: give correct information for the inner definition,

+ on outer definitions: give correct information for the outer definition.

Should hover and gotoDef do anything at all for signatures? or is the current
behaviour for outer signatures (doing nothing at all) what we want?

* Require signature hover/gotoDef to point to first clause of definition

* Remove perhaps superfluous tests for definitions
@jneira jneira linked a pull request Dec 28, 2020 that will close this issue
@simonmichael
Copy link
Contributor

stack became able to install ghc 8.10.3 in recent days (stack build --resolver ... --compiler ghc-8.10.3 ...).

@jneira
Copy link
Member

jneira commented Dec 30, 2020

@simonmichael thanks for noting it, we are building with stack using the compiler option in circleci: https://github.com/haskell/haskell-language-server/pull/699/files#diff-ceaaa3c4bbd2e628e86a2d16f3afb57e89317b8d442abff3d8a2ca1425b704c7

@jneira
Copy link
Member

jneira commented Jan 18, 2021

last hls version already supports ghc-8.10.3

@jneira jneira closed this as completed Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: blocked Not actionable, because blocked by upstream/GHC etc. type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants