Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tone down the implicit cradle import warnings #620

Closed
ndmitchell opened this issue Nov 24, 2020 · 4 comments · Fixed by #1511
Closed

Tone down the implicit cradle import warnings #620

ndmitchell opened this issue Nov 24, 2020 · 4 comments · Fixed by #1511

Comments

@ndmitchell
Copy link
Collaborator

Your environment

I am using HLS 0.6. Since I installed directly from VS Code I have no HLS or HLS wrapper on my path to probe tools. Windows, VS Code.

Steps to reproduce

Open Shake with no hie.yaml. Observe that each and every file I open produces a warning about an implicit prelude. I just dismissed 25 such warnings.

Expected behaviour

One warning. Once per session seems plenty.

Actual behaviour

Many warnings.

@expipiplus1
Copy link
Contributor

Or no warnings by setting a config option! I don't think I've ever changed my behavior after getting one of those warnings.

@ndmitchell
Copy link
Collaborator Author

Or maybe the warnings are no longer necessary? It used to be that an implicit cradle was a guarantee something would go wrong. Nowadays I have way more success with implicit cradles than explicit ones.

@jneira
Copy link
Member

jneira commented Nov 25, 2020

@ndmitchell i was a little bit confused for the

implicit prelude

in the description, i suppose you wanted to mean impicit cradle.

I think it works well enough to demote it again (was done from warning to info) to a log message

@ndmitchell
Copy link
Collaborator Author

ndmitchell commented Nov 26, 2020

Oops! Too much time dealing with implicit prelude stuff - thanks for the fix :). Agreed, a log message might be the way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants