Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demote implicit cradle warn to logging #1511

Merged
merged 1 commit into from Mar 7, 2021
Merged

Demote implicit cradle warn to logging #1511

merged 1 commit into from Mar 7, 2021

Conversation

jneira
Copy link
Member

@jneira jneira commented Mar 6, 2021

No description provided.

@pepeiborra
Copy link
Collaborator

What's the motivation for this change? Is there a related issue or conversation?

@jneira
Copy link
Member Author

jneira commented Mar 7, 2021 •
edited

What's the motivation for this change? Is there a related issue or conversation?

Sorry, i've forgotten to link the relevant issues: it would close #620, there you can see the links to other ones, closed as duplicated: #1259, #1229 and haskell/vscode-haskell#326
I've observed several beginners in the discord chat confused with that alert, moreover if they are experiencing some other issue. They dont know nothing about cradles, implicit or explicit and despite the message they tend to think it is related with their issue. (but some of them ask for the warning directly)

@jneira jneira linked an issue Mar 7, 2021 that may be closed by this pull request
Tone down the implicit cradle import warnings #620
Closed
@jneira jneira added the merge me Label to trigger pull request merge label Mar 7, 2021
@mergify mergify bot merged commit 2a99031 into haskell:master Mar 7, 2021
@michaelpj
Copy link
Collaborator

Seems like the commit still has it at a warning?

@ChrisPenner
Copy link

I've observed several beginners in the discord chat confused with that alert, moreover if they are experiencing some other issue. They dont know nothing about cradles, implicit or explicit and despite the message they tend to think it is related with their issue. (but some of them ask for the warning directly)

For additional context; in neovim with the Coc LSP the warning actually pops up a prompt that you have to manually dismiss. It only pops up once HLS has started initializing, meaning I'm often halfway through typing something and a prompt interrupts me, it's incredibly annoying haha. Very thankful this is fixed 🙌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpj michaelpj michaelpj left review comments

@pepeiborra pepeiborra pepeiborra approved these changes

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tone down the implicit cradle import warnings
4 participants
@jneira @pepeiborra @michaelpj @ChrisPenner