Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build with GHC 8.10 #937

Closed
chshersh opened this issue Apr 1, 2020 · 2 comments · Fixed by haskell/ghcide#519
Closed

Build with GHC 8.10 #937

chshersh opened this issue Apr 1, 2020 · 2 comments · Fixed by haskell/ghcide#519

Comments

@chshersh
Copy link
Member

chshersh commented Apr 1, 2020

I'm trying to build ghcide using recently released GHC 8.10. After updating dependencies correspondingly, I see the following error message:

src/Development/IDE/GHC/HieAst.hs:30:1: error:
    Could not find module ‘HsSyn’
    Use -v (or `:set -v` in ghci) to see a list of the files searched for.
   |
30 | import HsSyn
   | ^^^^^^^^^^^^

src/Development/IDE/GHC/HieAst.hs:37:37: error:
    Module ‘Type’ does not export ‘mkFunTys’
   |
37 | import Type                       ( mkFunTys, Type )
   |                                     ^^^^^^^^

I can see that at least the HsSyn module is not present in ghc-lib-parser-8.10.1.20200324.

cc @pepeiborra
@pepeiborra
Copy link
Collaborator

This is blocking us from upgrading to ghc 8.10

@ndmitchell
Copy link
Collaborator

The diff for HLint might be instructive - ndmitchell/hlint#934 suggests the kind of changes that will be required.

mpickering referenced this issue in mpickering/ghcide Apr 24, 2020
@mpickering
Squashed commit of the following:
910dcfc 
commit c91a7b8
Author: pepe iborra <pepeiborra@gmail.com>
Date:   Fri Apr 3 12:23:47 2020 +0100

    Add local fork of HieAst for 8.10.1

    The fix for mkHieFile didn't make it into 8.10.1, so the override is still needed

commit ac2d5da
Author: pepe iborra <pepeiborra@gmail.com>
Date:   Fri Apr 3 12:11:33 2020 +0100

    Revert changes to mkHieFile

commit 5dd5ee5
Author: Dmitrii Kovanikov <kovanikov@gmail.com>
Date:   Thu Apr 2 16:21:21 2020 +0100

    Move CPP logic to the Compat module

commit d7a9310
Author: Dmitrii Kovanikov <kovanikov@gmail.com>
Date:   Thu Apr 2 14:35:25 2020 +0100

    [#518] Build ghcide with GHC 8.10.1

    Resolves #518

commit 3960533
Author: Pepe Iborra <pepeiborra@gmail.com>
Date:   Fri Mar 27 17:54:15 2020 +0800

    Expose an option to control the number of Shake threads (haskell#504)
pepeiborra referenced this issue in pepeiborra/ghcide May 9, 2020
@chshersh @pepeiborra
[#518] Build ghcide with GHC 8.10.1
66f494f 
Resolves #518
cocreature referenced this issue in haskell/ghcide May 11, 2020
@chshersh @pepeiborra
[#518] Build ghcide with GHC 8.10.1 (#519)
07cf929 
* [#518] Build ghcide with GHC 8.10.1

Resolves #518

* Move CPP logic to the Compat module

* Revert changes to mkHieFile

* Add local fork of HieAst for 8.10.1

The fix for mkHieFile didn't make it into 8.10.1, so the override is still needed

* Ignore hlint in src-ghc810/HieAst.hs

* Whitelist CPP for Development.IDE.GHC.Orphans

* [#518] Build ghcide with GHC 8.10.1

Resolves #518

* Move CPP logic to the Compat module

* Revert changes to mkHieFile

* Add local fork of HieAst for 8.10.1

The fix for mkHieFile didn't make it into 8.10.1, so the override is still needed

* Ignore hlint in src-ghc810/HieAst.hs

* Whitelist CPP for Development.IDE.GHC.Orphans

* Plugin tests known broken in 8.10.1 (#556)

* Bump up ghc-check version

Co-authored-by: Pepe Iborra <pepeiborra@gmail.com>

Co-authored-by: pepe iborra <pepeiborra@gmail.com>
pepeiborra referenced this issue in pepeiborra/ide Dec 29, 2020
@chshersh @pepeiborra
[haskell/ghcide#518] Build ghcide with GHC 8.10.1 (haskell/ghcide#519)
b21472a 
* [haskell/ghcide#518] Build ghcide with GHC 8.10.1

Resolves haskell/ghcide#518

* Move CPP logic to the Compat module

* Revert changes to mkHieFile

* Add local fork of HieAst for 8.10.1

The fix for mkHieFile didn't make it into 8.10.1, so the override is still needed

* Ignore hlint in src-ghc810/HieAst.hs

* Whitelist CPP for Development.IDE.GHC.Orphans

* [haskell/ghcide#518] Build ghcide with GHC 8.10.1

Resolves haskell/ghcide#518

* Move CPP logic to the Compat module

* Revert changes to mkHieFile

* Add local fork of HieAst for 8.10.1

The fix for mkHieFile didn't make it into 8.10.1, so the override is still needed

* Ignore hlint in src-ghc810/HieAst.hs

* Whitelist CPP for Development.IDE.GHC.Orphans

* Plugin tests known broken in 8.10.1 (haskell/ghcide#556)

* Bump up ghc-check version

Co-authored-by: Pepe Iborra <pepeiborra@gmail.com>

Co-authored-by: pepe iborra <pepeiborra@gmail.com>
pepeiborra referenced this issue in pepeiborra/ide Dec 29, 2020
@chshersh @pepeiborra
[haskell/ghcide#518] Build ghcide with GHC 8.10.1 (haskell/ghcide#519)
0f2b089 
* [haskell/ghcide#518] Build ghcide with GHC 8.10.1

Resolves haskell/ghcide#518

* Move CPP logic to the Compat module

* Revert changes to mkHieFile

* Add local fork of HieAst for 8.10.1

The fix for mkHieFile didn't make it into 8.10.1, so the override is still needed

* Ignore hlint in src-ghc810/HieAst.hs

* Whitelist CPP for Development.IDE.GHC.Orphans

* [haskell/ghcide#518] Build ghcide with GHC 8.10.1

Resolves haskell/ghcide#518

* Move CPP logic to the Compat module

* Revert changes to mkHieFile

* Add local fork of HieAst for 8.10.1

The fix for mkHieFile didn't make it into 8.10.1, so the override is still needed

* Ignore hlint in src-ghc810/HieAst.hs

* Whitelist CPP for Development.IDE.GHC.Orphans

* Plugin tests known broken in 8.10.1 (haskell/ghcide#556)

* Bump up ghc-check version

Co-authored-by: Pepe Iborra <pepeiborra@gmail.com>

Co-authored-by: pepe iborra <pepeiborra@gmail.com>
pepeiborra referenced this issue in pepeiborra/ide Dec 29, 2020
@chshersh @pepeiborra
[haskell/ghcide#518] Build ghcide with GHC 8.10.1 (haskell/ghcide#519)
d7340e7 
* [haskell/ghcide#518] Build ghcide with GHC 8.10.1

Resolves haskell/ghcide#518

* Move CPP logic to the Compat module

* Revert changes to mkHieFile

* Add local fork of HieAst for 8.10.1

The fix for mkHieFile didn't make it into 8.10.1, so the override is still needed

* Ignore hlint in src-ghc810/HieAst.hs

* Whitelist CPP for Development.IDE.GHC.Orphans

* [haskell/ghcide#518] Build ghcide with GHC 8.10.1

Resolves haskell/ghcide#518

* Move CPP logic to the Compat module

* Revert changes to mkHieFile

* Add local fork of HieAst for 8.10.1

The fix for mkHieFile didn't make it into 8.10.1, so the override is still needed

* Ignore hlint in src-ghc810/HieAst.hs

* Whitelist CPP for Development.IDE.GHC.Orphans

* Plugin tests known broken in 8.10.1 (haskell/ghcide#556)

* Bump up ghc-check version

Co-authored-by: Pepe Iborra <pepeiborra@gmail.com>

Co-authored-by: pepe iborra <pepeiborra@gmail.com>
@pepeiborra pepeiborra transferred this issue from haskell/ghcide Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#518] Build ghcide with GHC 8.10.1
3 participants
@pepeiborra @ndmitchell @chshersh