Update to ghc-8.10.1 #934
Merged
Update to ghc-8.10.1 #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
shayne-fletcher
force-pushed
the
ghc-lib-8.10
branch
from
369d6b4
to
500f2f0
Compare
ndmitchell
reviewed
Mar 28, 2020
There was a problem hiding this comment.
Amazing work. The parse quick hack needs unwinding, since it breaks a few bits and pieces, but shouldn't be too hard. See 685051e#diff-28531b9ca053a7288b86a2e9d28dd5b9. I think it may be as simple as removing the pprLocErrMsg bit.
|
I just introduced and solved a merge commit on your branch, so you will need to pull/merge before rebasing. |
|
@ndmitchell Addressed the comments so far in the last two commits. Please cast your eye over once more. |
|
Oh, and there are some new test failures but I judge they have come in on your merge from master just now. |
|
Woohoo! Let's merge and then if there are any CI errors I'll fix them up in situ. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to the 8.10.1 parse tree.