Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lower bound to tasty-ant-xml #119

Merged
merged 1 commit into from
May 19, 2020

Conversation

jneira
Copy link
Member

@jneira jneira commented May 19, 2020

 - tasty-1.2.3 (lib) (requires download & build)
 - tasty-rerun-1.1.17 (lib) (requires download & build)
 - tasty-hunit-0.10.0.2 (lib) (requires download & build)
 - tasty-expected-failure-0.11.1.2 (lib) (requires download & build)
 - tasty-ant-xml-1.1.6 (lib) (requires download & build)
  • The next commit (mine! ✋ ) changed the hackage index from 2020-05-13T21:21:45Z to 2020-05-17T20:25:21Z and triggered the build error picking;
 - tasty-1.3.1 (lib) (requires download & build)
 - tasty-rerun-1.1.17 (lib) (requires download & build)
 - tasty-hunit-0.10.0.2 (lib) (requires download & build)
 - tasty-expected-failure-0.11.1.2 (lib) (requires download & build)
 - tasty-ant-xml-1.0.0.5 (lib) (requires download & build)

Not sure what is going on but adding a lower bound force cabal to pick the good version. Tested locally for ghc-8.6.4, ghc-8.6.5, ghc-8.8.3 y ghc-8.10.1

@jneira jneira requested a review from jeffwindsor May 19, 2020 18:27
Copy link
Collaborator

@jeffwindsor jeffwindsor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jneira not absolutely sure the reason, my best guess is that it something to do with the way tasty-ant-xml defines its dependency to tasty with an upper bound, but not really sure how that is confusing anything.

@jneira
Copy link
Member Author

jneira commented May 19, 2020

@jeffwindsor thanks for review this, the cabal build is green again and the stack ones are failing running tests as usual so merging this

@jneira jneira merged commit 7c8245b into haskell:master May 19, 2020
@jneira jneira deleted the constraint-tasty-ant-xml branch May 19, 2020 20:53
@jneira jneira mentioned this pull request May 25, 2020
pepeiborra pushed a commit that referenced this pull request Dec 27, 2020
* Remove warnings

* Turn on warnings when testing with Azure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants