Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare ghcide v0.7.3 release #1289

Merged
merged 5 commits into from Feb 2, 2021
Merged

Prepare ghcide v0.7.3 release #1289

merged 5 commits into from Feb 2, 2021

Conversation

pepeiborra
Copy link
Collaborator

No description provided.

@jneira
Copy link
Member

jneira commented Feb 1, 2021

The new hls-plugin-version will be 0.7.0.0: #1290

Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome :)

@pepeiborra
Copy link
Collaborator Author

The new hls-plugin-version will be 0.7.0.0: #1290

This was failing because hls-plugin-api 0.7.0.0 didn't exist.

In the future, its' best to change the build-depends in the same commit that bumps the version number, or after the version bump has landed. Otherwise, the version doesn't exist and the build fails :)

@jneira jneira added the merge me Label to trigger pull request merge label Feb 2, 2021
@jneira
Copy link
Member

jneira commented Feb 2, 2021

The bench is taking 2 hours....

@mergify mergify bot merged commit d602e45 into master Feb 2, 2021
jneira pushed a commit that referenced this pull request Feb 4, 2021
* Prepare ghcide v0.7.3 release

* bump hls-plugin-api minimum bound

Co-authored-by: Junyoung/Clare Jang <jjc9310@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants