Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[benchmarks] speed up CI #1315

Merged
merged 8 commits into from
Feb 7, 2021
Merged

[benchmarks] speed up CI #1315

merged 8 commits into from
Feb 7, 2021

Conversation

pepeiborra
Copy link
Collaborator

@pepeiborra pepeiborra commented Feb 6, 2021 •
edited
Loading

  • Disable parallel GC as it leads to occasional segfaults when combined with heap profiling
  • Lower the frequency of heap profiles to speed up benchmarks (I'll make it configurable in a follow-up change)
  • Reduce samples from 100 to 50 to speed up benchmarks

While I was there I also changed some of the artefact file extensions for consistency

@pepeiborra
[benchmark] disable parallel GC to avoid segfaults with -h
0cfd629
@pepeiborra
[benchmark] Lower the frequency of heap census to avoid starving the …
87e9615 
…mutator

Heap census is preceded by a GC pass. The default interval of 0.1 seconds causes
the mutator time to go down to 14% in the HLS example
@pepeiborra
[benchmark] change the extension used for -S files
71e75c4 
benchmark-gcStats was such an odd extension
@pepeiborra pepeiborra changed the title Speed up benchmarks [benchmarks] speed up CI Feb 6, 2021
jneira
jneira approved these changes Feb 6, 2021
View reviewed changes
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thans for improve ci times

@pepeiborra pepeiborra added the merge me Label to trigger pull request merge label Feb 6, 2021
@pepeiborra
Copy link
Collaborator Author

I thought that the benchmark job was the bottleneck, but I've sent 3 PRs today and they are all still in the CircleCI queue after >7h ....

@konn
Copy link
Collaborator

konn commented Feb 7, 2021 •
edited
Loading

Seems mergify got stuck, as its condition still requires bench for 8.8.4 and 8.10.2, not only for 8.10.3.

@pepeiborra pepeiborra mentioned this pull request Feb 7, 2021
Merged
@konn konn merged commit e7a75c1 into master Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wz1000 wz1000 wz1000 left review comments

@jneira jneira jneira approved these changes

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pepeiborra @konn @jneira @wz1000 @Ailrun