Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ghc-8.10.4 and drop it for ghc-8.10.1 #1331

Merged
merged 11 commits into from Feb 10, 2021

Conversation

jneira
Copy link
Member

@jneira jneira commented Feb 8, 2021

  • We dont have time and resources to support all possible ghc versions (as commented here) so, as we are supporting 8.8.2..8.8.4 i propose only support the last three minor version of each major version too for 8.10
  • This pr drops the unused (afaik) ci azure config
  • Closes Add ghc-8.10.4 support #1317

ghc8102 = extended (pkgs.haskell.packages.ghc8102.override sharedOverrides);
ghc8103 = extended (pkgs.haskell.packages.ghc8103.override sharedOverrides);
ghc8104 = extended (pkgs.haskell.packages.ghc8104.override sharedOverrides);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it this will work out of the box

@jneira
Copy link
Member Author

jneira commented Feb 8, 2021

What do you think in make a github release after adding ghc-8.10.4 support?, it would have hiedb included
//cc @pepeiborra @wz1000

@jneira
Copy link
Member Author

jneira commented Feb 8, 2021

When ci is green i will remove the github required checks for ghc-8.10.1 and add ghc-8.10.4 ones

Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, Thanks. I hope there's no one left behind with GHC 8.10.1...

@wz1000
Copy link
Collaborator

wz1000 commented Feb 9, 2021

I'm OK with a release.

There have been no bug reports about hiedb so far, so either its working as intended (yay!), or nobody is using it. If its the latter, I'm ready for people to start dropping the bug reports once they start using it.

@jneira
Copy link
Member Author

jneira commented Feb 9, 2021

I need some window time to

  1. disable actual ci checks for the test suite for 8.10.3
  2. merge the pr
  3. enable new ci checks for the test suite and 8.10.4

and no merge other pr's with a failing test suite between 1 and 2

Then we should update the rest of pr's (that is enforced by github)

@Ailrun
Copy link
Member

Ailrun commented Feb 9, 2021

I think we can do 1. and 3. together. If so, all other PRs cannot be merged until this one is merged. (and so we don't need a special time window)

@jneira
Copy link
Member Author

jneira commented Feb 9, 2021

yeah, I didn't want block anyone though, I will wait until I come home and will change them if I can't do the switch &merge fast

@jneira jneira merged commit 2dcf2c6 into haskell:master Feb 10, 2021
@jneira jneira deleted the ghc-8.10.4 branch February 10, 2021 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ghc-8.10.4 support
3 participants