Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eval Plugin: Proper handling of flags in :set #1343

Merged
merged 5 commits into from
Feb 11, 2021
Merged

Conversation

konn
Copy link
Collaborator

@konn konn commented Feb 10, 2021

As outlined in #1278, this PR uses parseDynamicFlagsCmdLine to make the :set command in Eval Plugin compatible with dynamic flags other than language extensions.

Fixes #1278.

@konn konn requested review from jneira and lukel97 February 10, 2021 07:43
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice self explanatory test case

@jneira jneira added the merge me Label to trigger pull request merge label Feb 11, 2021
@mergify mergify bot merged commit 91990de into master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extended Eval Plugin: we need more precise handling of :setting flags
2 participants