Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use implicit-hie cradle #138

Closed
wants to merge 1 commit into from

Conversation

Avi-D-coder
Copy link
Collaborator

@Avi-D-coder Avi-D-coder commented May 27, 2020

Companion to #110

@Avi-D-coder
Copy link
Collaborator Author

Avi-D-coder commented May 28, 2020

There's a issue with stack and exe/Main.hs Just took a minute to load.

@Avi-D-coder
Copy link
Collaborator Author

Avi-D-coder commented May 28, 2020

Followup to this would be preferred cabal or stack config. I thought about doing this via hie.yaml, but that's the wrong approach it should be a LSP config, since hie.yamls are often committed.

Is it easy to make cabal-helper follow this config? I have not yet looked into it.

@fendor
Copy link
Collaborator

fendor commented May 28, 2020

cabal-helper can implement this behaviour easily. Just filter for the project context, if there is none report an error, otherwise use the context

@Avi-D-coder
Copy link
Collaborator Author

Avi-D-coder commented Jun 21, 2020

In light of yet another reddit post by someone confused by hie.yaml.

It's better then nothing

I would like to push for this to be merged, it does not always generate the exact right config, but it works for ever config a beginner would use. When it fails, the hie-bios no cradle matched error message is decipherable. When using conditionals or common stanzas, more advanced users will still have to write an hie.yaml, but they will have a good error message and a tool implicit-hie to help them.

There are better solutions in the pipeline, but that should not stop us from improving user experience now. Let's not let perfect be the enemy of good.

@jneira
Copy link
Member

jneira commented Jun 21, 2020

Agree, i thought a more complete version would be ready sooner.
However i think that it would need a specific section in the readme, specifying in which known cases the implicit config will not work for sure.

Comment on lines +16 to +19
source-repository-package
type: git
location: https://github.com/mpickering/hie-bios
tag: a852cffb0deb306cd1e1fe02aa50d50c77aeb15d
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unneeded, afaict?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Please rebase, maybe some words in the README how your tool can be used to generate a hie.yaml config

stack-8.10.1.yaml Show resolved Hide resolved
stack-8.6.4.yaml Show resolved Hide resolved
stack-8.6.5.yaml Show resolved Hide resolved
stack-8.8.2.yaml Show resolved Hide resolved
stack-8.8.3.yaml Show resolved Hide resolved
stack.yaml Show resolved Hide resolved
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the wrapper needs to be modified, otherwise it will continue to use cabal-helper.
The change should be of the same size.

@Avi-D-coder
Copy link
Collaborator Author

I'll rebase, when I get a chance hopefully tomorrow, very busy.

@Avi-D-coder
Copy link
Collaborator Author

@fendor I'm in the process of rebasing, but hie-bios has changed, how soon before the next hie-bios release. Unless we want hls to depend on an out of date, but still not published hie-bio commit we need to wait until hls is using a newer hie-bios.

@fendor
Copy link
Collaborator

fendor commented Jun 22, 2020

@Avi-D-coder I want to hopefully do a release this week, but there are three pending PRs that need to be reviewed and merged. So, unfortunately, no promises.
Maybe we can do a minor release before the major release.

@alanz
Copy link
Collaborator

alanz commented Jun 25, 2020

@fendor @Avi-D-coder what is holding this up? I think it is important we get it in.

@fendor
Copy link
Collaborator

fendor commented Jun 25, 2020

@alanz A hie-bios release that includes: haskell/hie-bios@a852cff
I will get to it tomorrow.

@Avi-D-coder
Copy link
Collaborator Author

New version of hie-bios needs to be released, ghcide & hls need to use it, and then I need to find time to rebase and fix the wrapper.

@alanz
Copy link
Collaborator

alanz commented Jun 25, 2020

Ok, so it is waiting, rather than abandoned. Thanks.

@Avi-D-coder
Copy link
Collaborator Author

Rebased at #186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants