Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable HLS example benchmark #1412

Merged
merged 2 commits into from Feb 21, 2021
Merged

Reenable HLS example benchmark #1412

merged 2 commits into from Feb 21, 2021

Conversation

pepeiborra
Copy link
Collaborator

The example was commented out in #1388

@wz1000
Copy link
Collaborator

wz1000 commented Feb 20, 2021

hie-bios has been updated. Should we check if it fixes the timeouts?

@pepeiborra
Copy link
Collaborator Author

Oh, that's a good point, let me repurpose the PR

@pepeiborra pepeiborra changed the title Remove bench_example_HLS from benchmark matrix Reenable HLS example benchmark Feb 20, 2021
@wz1000
Copy link
Collaborator

wz1000 commented Feb 20, 2021

Benchmarks didn't time out but all of them failed :(

I've also noticed that all the "code actions" benchmarks have been failing for lsp-test since at least the hie-bios update.

Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, now it works! Thank you

@Ailrun Ailrun added the merge me Label to trigger pull request merge label Feb 21, 2021
@Ailrun Ailrun merged commit da496a1 into haskell:master Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants