Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code action for importing class methods #1428

Merged
merged 7 commits into from Feb 25, 2021
Merged

Add code action for importing class methods #1428

merged 7 commits into from Feb 25, 2021

Conversation

berberman
Copy link
Collaborator

@berberman berberman commented Feb 23, 2021 •
edited by Ailrun

Resolves partially #1423

Pre-commit hook didn't run successfully:

ghcide/test/exe/Main.hs: RealSrcSpan SrcSpanPoint "ghcide/test/exe/Main.hs" 4080 5: parse error (possibly incorrect indentation or mismatched brackets)

@Ailrun
Copy link
Member

Ailrun commented Feb 23, 2021

I think the issue also requires a change of class plugin, so this PR partially resolves it, not fully closes it.

konn
konn approved these changes Feb 24, 2021
View reviewed changes
Copy link
Collaborator

@konn konn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@berberman
Copy link
Collaborator Author

Windows test is failing: #1430

@berberman berberman added the merge me Label to trigger pull request merge label Feb 25, 2021
@mergify mergify bot merged commit f21ea28 into haskell:master Feb 25, 2021
@berberman berberman deleted the class-methods branch February 25, 2021 05:43
This was referenced Mar 7, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konn konn konn approved these changes

@pepeiborra pepeiborra Awaiting requested review from pepeiborra

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@berberman @Ailrun @konn