Faster ModSummary fingerprints #1485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wz1000
reviewed
Mar 3, 2021
wz1000
reviewed
Mar 3, 2021
The computation of these fingerprints was very suboptimal. This change: - Avoids calling Hdr.getOptions twice - Shares the relevant part of the fingerprint between GetModSummary and GetModSummaryWihoutTimestamps - skips the timestamps altogether, since we already fingerprint the preprocessed - buffer. - Avoids show in the fingerprint computation - Uses efficient fingerprint primitives
pepeiborra
force-pushed
the
faster-modsummary-fingerprint
branch
from
392c092 to
115d063
Compare
wz1000
approved these changes
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The computation of the GetModSummary rule fingerprints was very suboptimal.
This change: