Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ISSUE_TEMPLATE.md #1640

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Update ISSUE_TEMPLATE.md #1640

merged 1 commit into from
Mar 30, 2021

Conversation

Ailrun
Copy link
Member

@Ailrun Ailrun commented Mar 30, 2021

To include OS

jneira
jneira approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that was fast, many thanks

@Ailrun Ailrun added the merge me Label to trigger pull request merge label Mar 30, 2021
@Ailrun
Copy link
Member Author

Ailrun commented Mar 30, 2021

@jneira Unfortunately, it looks like CI skipping still does not work... Maybe we are skipping things too early?

@Ailrun
Copy link
Member Author

Ailrun commented Mar 30, 2021

Anyway, I will merge this manually for now

@Ailrun Ailrun merged commit d60dee0 into master Mar 30, 2021
@Ailrun Ailrun removed the merge me Label to trigger pull request merge label Mar 30, 2021
@jneira
Copy link
Member

jneira commented Mar 30, 2021

mmm in the report I see 12/16 successful checks and there are 4 circleci unfinished jobs (they are not skipped only gha ones)

@Ailrun
Copy link
Member Author

Ailrun commented Mar 30, 2021

@jneira The report says that, but the GitHub branch rule does not work with that 12 successful checks.

@jneira
Copy link
Member

jneira commented Mar 30, 2021

mmm after circleci jobs has finished all checks are green and I think you had been able to merge it
as commented above circleci jobs are not affected by any skip rule so they are executed and handled like in any other pr (so you can't merge if they fail or are unfinished)

@Ailrun
Copy link
Member Author

Ailrun commented Mar 30, 2021

@jneira Maybe it's better to show this in a test PR. I will send an ad-hoc PR for this.

@Ailrun Ailrun deleted the update-issue-template branch April 3, 2021 15:41
berberman pushed a commit to berberman/haskell-language-server that referenced this pull request Apr 4, 2021
@Ailrun @berberman
Update ISSUE_TEMPLATE.md (haskell#1640)
f38227c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ailrun @jneira