Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add haskell-language-server-bin to Arch Linux section #1642

Merged
merged 4 commits into from
Apr 5, 2021

Conversation

marcin-rzeznicki
Copy link
Contributor

See #1634

@jneira jneira requested a review from berberman March 30, 2021 22:03
@@ -140,6 +140,8 @@ To install, download the `haskell-language-server-wrapper` executable for your p

### Arch Linux

The preferred method of installation for development purposes is to use the [haskell-language-server-bin](https://aur.archlinux.org/packages/haskell-language-server-bin) package from AUR. This package contains statically linked binaries for each supported GHC version and `haskell-language-server-wrapper` for dynamic GHC version selection. It is updated regularly, requires no additional dependencies, and is independent of other haskell packages you may have on your system, including GHC. Its size is relatively large (approx. 900 MB), but if this is a problem for you, during installation you can disable the GHC versions you will not be using by editing the PKGBUILD file.

Copy link
Member

@Ailrun Ailrun Mar 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's maybe better to update the following paragraph so that they flow better.

Copy link
Contributor Author

@marcin-rzeznicki marcin-rzeznicki Mar 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to admit that I like how they flow and it seems logical to me: The preferred method (...) is (...) . If you're using [something else] then (...). But I'm open to suggestions

Copy link
Member

@Ailrun Ailrun Mar 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean we may put some connection words like

- If you are using ArchLinux with **dynamically linked** ... you can ...
+ Alternatively if you are using **dynamically linked** ... you can also ...

and removing "ArchLinux" as this paragraph is already quite far from the section title, it feels a bit awkward to mention "ArchLinux" again...
Though I'm not strongly inclined towards this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good idea

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 7d7d83e

Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is by mistake, so NVM

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@berberman berberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@berberman berberman added the merge me Label to trigger pull request merge label Apr 5, 2021
@mergify mergify bot merged commit 334f185 into haskell:master Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants