Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ghcide and HLS enter lsp mode by default #1692

Merged
merged 1 commit into from Apr 8, 2021
Merged

Fix ghcide and HLS enter lsp mode by default #1692

merged 1 commit into from Apr 8, 2021

Conversation

berberman
Copy link
Collaborator

@berberman berberman commented Apr 8, 2021 •
edited

We can't use switch with alternative combinators, since it never fails.

pepeiborra
pepeiborra approved these changes Apr 8, 2021
View reviewed changes
Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! I always make the same mistake with these combinators that never fail

@pepeiborra pepeiborra merged commit 97d8965 into master Apr 8, 2021
@berberman berberman deleted the exe-main branch April 8, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepeiborra pepeiborra pepeiborra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@berberman @pepeiborra