Improve vscode extension schema generation #1742
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in haskell/vscode-haskell#378 (comment), in order to make the generated vscode extension schema more handy, this PR introduces a new data type taking place of the old
pluginCustomConfig
inPluginDescriptor
:configHasDiagnostics
toTrue
explicitly in plugin like hlint, so that we could generatediagnosticsOn
option for it.globalOn
option only if it has one capability; otherwise we use specific capabilities such ascodeActionOn
,codeLensOn
, etc. as options.configEnableGenericConfig
toFalse
to avoid generating options of this plugin.