Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flake compat #1852

Merged
merged 2 commits into from
May 21, 2021
Merged

Fix flake compat #1852

merged 2 commits into from
May 21, 2021

Conversation

berberman
Copy link
Collaborator

Closes #1846

We should enter devShell rather than the shell of defaultPackage.

Copy link

@ErnestKz ErnestKz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, just some questions to help me learn:

In theory would keeping the file named default.nix still work? What does the .shellNix do on the flake import? Is the .shellNix something that's defined outside of this repo?

Also thank you for fixing this.

@berberman
Copy link
Collaborator Author

In theory would keeping the file named default.nix still work?

Yes, nix-shell will use default.nix if there is no shell.nix.

What does the .shellNix do on the flake import? Is the .shellNix something that's defined outside of this repo?

It's defined in https://github.com/edolstra/flake-compat/blob/master/default.nix, which basically allows you use flakes with the legacy nix commands (nix-build and nix-shell). You can find more details in "Using flakes project from a legacy Nix" of https://nixos.wiki/wiki/Flakes.

Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@Ailrun Ailrun added the merge me Label to trigger pull request merge label May 21, 2021
@Ailrun Ailrun merged commit bc4a119 into master May 21, 2021
@berberman berberman deleted the nix-flakes-compat branch May 21, 2021 21:53
@Ailrun Ailrun removed the merge me Label to trigger pull request merge label May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contributing via nix-env doesn't work, zlib seems to be missing from derivation
3 participants