Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use last apply-refact and several stack.yaml updates #1858

Merged
merged 16 commits into from May 24, 2021

Conversation

jneira
Copy link
Member

@jneira jneira commented May 22, 2021

  • cabal side: update hackage index and bump up min apply-refact version
  • stack side:
    • set the new apply-refact version (it needed bump up brittany version too)
    • drop stack.yaml for 8.10.2 and 8.8.2
    • make stack-8.10.4.yaml the default one copying into the stack.yaml
    • bump up hie-bios to 0.7.5

Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

.circleci/config.yml Outdated Show resolved Hide resolved
@@ -1,10 +1,10 @@
resolver: lts-14.27 # Last 8.6.5
resolver: lts-17.12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this update :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, 8.10.4 windows version seems to be reliable enough to make it the default

stack-8.10.3.yaml Show resolved Hide resolved
@jneira
Copy link
Member Author

jneira commented May 23, 2021

  • benchamark is failing in the solver phase with:
Resolving dependencies...
cabal: Could not resolve dependencies:
[__0] trying: ghcide-1.3.0.0 (user goal)
[__1] trying: lsp-test-0.14.0.0 (dependency of ghcide)
[__2] trying: some-1.0.3 (dependency of lsp-test)
[__3] trying: lsp-types-1.2.0.0 (dependency of ghcide)
[__4] next goal: dependent-sum (dependency of ghcide)
[__4] rejecting: dependent-sum-0.7.1.0 (conflict: some==1.0.3, dependent-sum
=> some>=1.0.1 && <1.0.3)
[__4] skipping: dependent-sum-0.7.0.0 (has the same characteristics that
caused the previous version to fail: excludes 'some' version 1.0.3)
[__4] rejecting: dependent-sum-0.6.2.0 (conflict: lsp-types =>
dependent-sum>=0.6.2.2)
[__4] skipping: dependent-sum-0.5, dependent-sum-0.4, dependent-sum-0.3.2.2,
dependent-sum-0.3.2.1, dependent-sum-0.3.2.0, dependent-sum-0.3.1.0,
dependent-sum-0.2.1.0, dependent-sum-0.2.0.2, dependent-sum-0.2.0.1,
dependent-sum-0.2, dependent-sum-0.1 (has the same characteristics that caused
the previous version to fail: excluded by constraint '>=0.6.2.2' from
'lsp-types')
[__4] rejecting: dependent-sum-0.6.2.2 (conflict: some==1.0.3, dependent-sum
=> some>=1.0.0.3 && <1.0.1)
[__4] rejecting: dependent-sum-0.6.1 (conflict: lsp-types =>
dependent-sum>=0.6.2.2)
[__4] skipping: dependent-sum-0.6 (has the same characteristics that caused
the previous version to fail: excluded by constraint '>=0.6.2.2' from
'lsp-types')
[__4] fail (backjumping, conflict set: dependent-sum, ghcide, lsp-types, some)
Backjump limit reached (currently 10000, change with --max-backjumps or try to
run with --reorder-goals).

i will try to increase the limit (already increased recently)

  • nix build with
3.2.1.0:Distribution.Simple.UserHooks
       >   configureAction, called at libraries/Cabal/Cabal/Distribution/Simple.hs:180:19 in Cabal-3.2.1.0:Distribution.Simple
       >   defaultMainHelper, called at libraries/Cabal/Cabal/Distribution/Simple.hs:116:27 in Cabal-3.2.1.0:Distribution.Simple
       >   defaultMain, called at /nix/store/4mdp8nhyfddh7bllbi7xszz7k9955n79-Setup.hs:2:8 in main:Main
       > Setup: Encountered missing or private dependencies:
       > apply-refact >=0.9.3.0
       >

I hope #1859 could help to workareound this, not sure why it does not work though, bumping up versions in .cabal file to get fixes is a very common task 🤔

.github/workflows/bench.yml Outdated Show resolved Hide resolved
@jneira jneira merged commit da72a27 into haskell:master May 24, 2021
berberman added a commit to berberman/haskell-language-server that referenced this pull request May 26, 2021
berberman added a commit to berberman/haskell-language-server that referenced this pull request May 27, 2021
berberman added a commit to berberman/haskell-language-server that referenced this pull request May 27, 2021
berberman added a commit that referenced this pull request May 27, 2021
* Fix nix build for #1858

* Update skip paths

* Run job nix build on PRs that change nix files

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax error after hlint refactor
2 participants