Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add manual upload instructions #1930

Merged
merged 3 commits into from Jun 16, 2021
Merged

Add manual upload instructions #1930

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d55d4f5
Add manual upload instructions
jneira Jun 16, 2021
383981d
Add the local build case
jneira Jun 16, 2021
7d1c7e6
Add missing whitespace
jneira Jun 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 10 additions & 1 deletion docs/releases.md
View file
Open in desktop
Expand Up @@ -85,9 +85,18 @@ we make sure to upload them as their full name variant.

If the workflow fail and all of some binaries has not been uploaded,
the prerelease and the tag itself has to be recreated to start it again.
If only some of the artefacts are missinf an alternative could be make
If only some of the artefacts are missing, an alternative could be make
the release in a fork and upload manually them.

If they are missing due to ci specific problems we can build the executable locally.

To manually upload the missing binary we should:

- Add the new tar/zip following the name conventions of existing ones
- `haskell-language-server-${os}-${ghcVersion}.gz` for `Linux` and `macOS` and `haskell-language-server-Windows-${ghcVersion}.exe.zip` for `Windows`
- the binary inside the gz file is named `haskell-language-server-${ghcVersion}` (with the `.exe` extension for `Windows`). Note that the binary name does not contain the `${os}` part.
- Add the executable to the existing tar `haskell-language-server-${os}-${ghcVersion}.tar.gz` following the same schema for the binary as the previous one.

### ghcup
Ghcup can install hls binaries, provided that there is a tarfile
called `haskell-language-server-{macOS,Linux}-$HLS_VERSION.tar.gz`
Expand Down