Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[benchmarks] Fix edit and "after edit" experiments #2122

Merged
merged 1 commit into from Aug 22, 2021
Merged

[benchmarks] Fix edit and "after edit" experiments #2122

merged 1 commit into from Aug 22, 2021

Commits on Aug 22, 2021

  1. Fix "after edit" experiments 

    When the example includes >1 modules, we have to wait for the progress
start of every edit. This is the sequence of events:

--> didChange A.hs
--> didChange B.hs
<-- ProgressStart (for A.hs change)
<-- ProgressDone (aborted)
<-- ProgressStart (for B.hs change)
<-- ProgressDone

The experiment needs to ignore the aborted progress done events and wait until the last progress done event.
To accomplish this, we wait for all the progress start events and then
wait for one progress done event
    @pepeiborra
    pepeiborra committed Aug 22, 2021
    Configuration menu
    Copy the full SHA
    6e738f7 View commit details
    Browse the repository at this point in the history