Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move hlint tests to its own package (and other clean ups) #2284

Merged
merged 15 commits into from Oct 22, 2021
Merged

Move hlint tests to its own package (and other clean ups) #2284

merged 15 commits into from Oct 22, 2021

Conversation

jneira
Copy link
Member

@jneira jneira commented Oct 20, 2021 •
edited

  • Almost all plugins has its tests in the package but hlint, it was time to do it
  • As preparatory work to write some regressions tests for existing hlint issue (in a floow up pr)
  • Other refactors:
    • Remove test/tesdata/cabal-helper as it was not used anywhere
    • Extract some functions to hls-test-utils: sendConfigurationChanged , noLiteralCaps

Ailrun
Ailrun approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this one is basically copy-and-paste with fixes like test/testdata/diagnostics/foo.hs or so, right? LGTM.

@jneira jneira added the merge me Label to trigger pull request merge label Oct 22, 2021
@mergify mergify bot merged commit fffc04d into haskell:master Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ailrun Ailrun Ailrun approved these changes

@pepeiborra pepeiborra Awaiting requested review from pepeiborra

@michaelpj michaelpj Awaiting requested review from michaelpj michaelpj is a code owner

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jneira @Ailrun