[hls-graph] clean up databaseDirtySet #2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jneira
approved these changes
Oct 23, 2021
pepeiborra
force-pushed
the
cleanup-dirtyset
branch
2 times, most recently
from
b166f18
to
836a488
Compare
jneira
reviewed
Oct 24, 2021
pepeiborra
force-pushed
the
cleanup-dirtyset
branch
from
352c349
to
dc259e9
Compare
jneira
reviewed
Oct 24, 2021
jneira
reviewed
Oct 24, 2021
pepeiborra
force-pushed
the
cleanup-dirtyset
branch
from
a8bbd30
to
aeb10b0
Compare
jneira
reviewed
Oct 24, 2021
pepeiborra
force-pushed
the
cleanup-dirtyset
branch
from
0395e03
to
225b5ae
Compare
it looks like the test runner has a preexisting process locking the hiedb
pepeiborra
force-pushed
the
cleanup-dirtyset
branch
from
4d4ec05
to
f3f13fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another spinoff from #2263 to clean up some of the dirty keys code in his-graph.
When I ported https://github.com/ndmitchell/shake/pull/802/files to hls-graph, I changed the encoding of the dirty set. Instead,
Dirtybecame a constructor in theStatusunion. But thedatabaseDirtySetstayed around accidentally, leading to some confusion.