Not suggest exported imports #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshitsugu
commented
Nov 5, 2021
jneira
reviewed
Nov 5, 2021
| @@ -32,3 +32,16 @@ library | |||
| default-extensions: | |||
| DataKinds | |||
| TypeOperators | |||
|
|
|||
| test-suite tests | |||
There was a problem hiding this comment.
Wow the plugin had no test suite??? Many thanks for adding it, a great contribution in its own
There was a problem hiding this comment.
It would be great to add it to the github workflow to run them in ci, adding an entry like
haskell-language-server/.github/workflows/test.yml
Lines 207 to 209 in a0cd84b
|
Many thanks for your new contribution! |
pepeiborra
approved these changes
Nov 5, 2021
michaelpj
reviewed
Nov 5, 2021
Co-authored-by: Michael Peyton Jones <me@michaelpj.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I attempted to fix #2079
I'm not familiar with GHC AST kind things. I'd be happy to get some advice if anyone has more smart way to implement this.