Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show build graph statistics in ghcide-bench #2343

Merged
merged 3 commits into from Nov 11, 2021
Merged

Conversation

pepeiborra
Copy link
Collaborator

@pepeiborra pepeiborra commented Nov 10, 2021

This adds 5 new columns to the benchmark outputs:

  • buildRulesBuilt - for which the value didn't change
  • buildRulesChanged - for which the value did change
  • buildRulesVisited - for which the value was not even recomputed
  • buildRulesTotal - including the rules that were not visited in the last build
  • buildEdges - total number of edges in the build graph

Example output:

cabal exec cabal run ghcide-bench -- -- -s "edit" --samples 2 --no-clean --example-module Distribution/Simple.hs
Up to date
Config {verbosity = Normal, shakeProfiling = Nothing, otMemoryProfiling = Nothing, outputCSV = "results.csv", buildTool = Cabal, ghcideOptions = [], matches = ["edit"], repetitions = Just 2, ghcide = "ghcide", timeoutLsp = 60, example = Example {exampleName = "name", exampleDetails = Right (ExamplePackage {packageName = "Cabal", packageVersion = Version {versionBranch = [3,4,0,0], versionTags = []}}), exampleModules = ["Distribution/Simple.hs"], exampleExtraArgs = []}}
starting test
Setting up document contents took 1.95s
Running edit benchmark
0.00s
0.17s
name | success | samples | startup | setup | userTime | delayedTime | totalTime | buildRulesBuilt | buildRulesChanged | buildRulesVisited | buildRulesTotal | buildEdges
---- | ------- | ------- | ------- | ----- | -------- | ----------- | --------- | --------------- | ----------------- | ----------------- | --------------- | ----------
edit | True    | 2       | 1.98s   | 0.00s | 0.17s    | 1.61s       | 1.78s     | 8               | 7                 | 1219              | 6345            | 148658   

This adds 5 new columns to the benchmark outputs:

- buildRulesBuilt   - for which the value didn't change
- buildRulesChanged - for which the value did change
- buildRulesVisited - for which the value was not even recomputed
- buildRulesTotal   - including the rules that were not visited in the last build
- buildEdges        - total number of edges in the build graph
@mergify mergify bot merged commit 9639bd0 into master Nov 11, 2021
pepeiborra added a commit that referenced this pull request Nov 14, 2021
* Show build graph statistics in ghcide-bench

This adds 5 new columns to the benchmark outputs:

- buildRulesBuilt   - for which the value didn't change
- buildRulesChanged - for which the value did change
- buildRulesVisited - for which the value was not even recomputed
- buildRulesTotal   - including the rules that were not visited in the last build
- buildEdges        - total number of edges in the build graph

* Fix build

* backwards compat.
pepeiborra added a commit that referenced this pull request Nov 16, 2021
* Show build graph statistics in ghcide-bench

This adds 5 new columns to the benchmark outputs:

- buildRulesBuilt   - for which the value didn't change
- buildRulesChanged - for which the value did change
- buildRulesVisited - for which the value was not even recomputed
- buildRulesTotal   - including the rules that were not visited in the last build
- buildEdges        - total number of edges in the build graph

* Fix build

* backwards compat.
pepeiborra added a commit that referenced this pull request Nov 19, 2021
* Show build graph statistics in ghcide-bench

This adds 5 new columns to the benchmark outputs:

- buildRulesBuilt   - for which the value didn't change
- buildRulesChanged - for which the value did change
- buildRulesVisited - for which the value was not even recomputed
- buildRulesTotal   - including the rules that were not visited in the last build
- buildEdges        - total number of edges in the build graph

* Fix build

* backwards compat.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants