slightly better shell.nix for local development #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pepeiborra
commented
Jul 25, 2020
pepeiborra
commented
- Pins nixpkgs using niv
- Allows to select the version of ghc
- Preloads a few heavy weight packages
- Adds flint to the environment
pepeiborra
pushed a commit
that referenced
this pull request
Dec 27, 2020
We have seen a bunch of failures on CI where this failed with EBUSY. I find the hDuplicateTo here to be quite useful for debugging since you don’t have to worry about corrupting the JSON-RPC stream to instead of getting rid of it, we add a somewhat ugly workaround. There is an explanation in an inline comment on why this helps but admittedly I am somewhat guessing since I don’t understand what is actually allocating the file descriptor that turns out to be stdout. That said, I am not guessing on the results: Without this PR I am able to make this fail in roughly 50% of the cases on CI whereas with this PR, I’ve now run it 60 times on CI without a single failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.