Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghcide: Update dependency on hls-plugin-api #2382

Merged
merged 2 commits into from Nov 22, 2021

Conversation

hololeap
Copy link
Contributor

@hololeap hololeap commented Nov 21, 2021

2204a16 broke backward compatibility between ghcide and hls-plugin-api

In addition to this PR, the following will need to be revised on hackage:

Versions 1.4.1.0 1.4.2.0 1.4.2.1 1.4.2.2 1.4.2.3 will need
hls-plugin-api ^>= 1.2.0.0
changed to
hls-plugin-api >= 1.2.0.0 && < 1.2.0.2

Version 1.5.0 will need
hls-plugin-api ^>= 1.2.0.0
changed to
hls-plugin-api ^>= 1.2.0.2

@hololeap
Copy link
Contributor Author

When building ghcide-1.4.2.2 on top of hls-plugin-api-1.2.0.2:

src/Development/IDE/Types/Options.hs:140:29: error:
    Data constructor not in scope: CheckOnSaveAndClose :: CheckParents
    |
140 |     ,optCheckParents = pure CheckOnSaveAndClose
    |                             ^^^^^^^^^^^^^^^^^^^

Building ghcide-1.4.2.2 on top of hls-plugin-api-1.2.0.1 works correctly

2204a16 broke backward compatibility
between `ghcide` and `hls-plugin-api`
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, will need hackage revision

@jneira jneira added the merge me Label to trigger pull request merge label Nov 22, 2021
@mergify mergify bot merged commit 0a55e9c into haskell:master Nov 22, 2021
@jneira
Copy link
Member

jneira commented Nov 22, 2021

Versions 1.4.1.0 1.4.2.0 1.4.2.1 1.4.2.2 1.4.2.3 will need
hls-plugin-api ^>= 1.2.0.0
changed to
hls-plugin-api >= 1.2.0.0 && < 1.2.0.2

Version 1.5.0 will need
hls-plugin-api ^>= 1.2.0.0

@jneira
Copy link
Member

jneira commented Nov 22, 2021

@hololeap all revisions done, many thanks for help us to keep correct bounds //cc @pepeiborra

@hololeap hololeap deleted the ghcide-deps branch November 22, 2021 10:44
hololeap added a commit to hololeap/gentoo-haskell that referenced this pull request Nov 27, 2021
Restrict versions of dependency `hls-plugin-api`
Bug: haskell/haskell-language-server#2382

Fix typo in `src_configure()`

Package-Manager: Portage-3.0.28, Repoman-3.0.3
Signed-off-by: hololeap <hololeap@users.noreply.github.com>
hololeap added a commit to hololeap/gentoo-haskell that referenced this pull request Nov 29, 2021
Restrict versions of dependency `hls-plugin-api`
Bug: haskell/haskell-language-server#2382

Fix typo in `src_configure()`

Package-Manager: Portage-3.0.28, Repoman-3.0.3
Signed-off-by: hololeap <hololeap@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants