Lock-less hls-graph #2411
Merged
Lock-less hls-graph #2411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jneira
approved these changes
Nov 29, 2021
Check the comment on the mother PR, performance does regress with j2 but is competitive with j4. This is expected and I think it's a reasonable trade off. |
thanks for the reference,it seems the loss is reasonable, will complain if it is not as i have to live with 2 cores in my main dev laptop 😝 |
|
Let's not merge this just yet |
drsooch
pushed a commit
to drsooch/haskell-language-server
that referenced
this pull request
Dec 3, 2021
* Fix incomplete pattern match warning in 8.8 * lock-less hls-graph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR extracted from #2357. While I don't have performance measurements for this change alone, the final performance results are in #2357 (comment)