Lockless diagnostics #2434
Merged
Lockless diagnostics #2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
approved these changes
Dec 3, 2021
michaelpj
reviewed
Dec 3, 2021
| -> STM (IO ()) | ||
| recordDirtyKeys ShakeExtras{dirtyKeys} key file = do | ||
| modifyTVar' dirtyKeys $ \x -> foldl' (flip HSet.insert) x (toKey key <$> file) | ||
| return $ withEventTrace "recordDirtyKeys" $ \addEvent -> do |
There was a problem hiding this comment.
Hmm interesting. I guess we may end up with this happening a bit if we push STM out further and we hit more places where we want to do tracing. I wonder if this is a pattern that appears elsewhere: this is something like a "final" IO action that should be run only after the STM action succeeds.
Stderr output is very useful to diagnose test failures when interleaved with the LSP log. Sending it to a file disrupts this interleaving and makes it harder to retrieve from CI
pepeiborra
force-pushed
the
lockless-diagnostics
branch
from
b802fcb
to
43220a0
Compare
fendor
reviewed
Dec 9, 2021
Comment on lines
248
to
+250
| let invalidateShakeCache = do | ||
| void $ modifyVar' version succ | ||
| recordDirtyKeys extras GhcSessionIO [emptyFilePath] | ||
| atomically $ recordDirtyKeys extras GhcSessionIO [emptyFilePath] |
There was a problem hiding this comment.
I just noticed, this changes the type of invalidateShakeCache to :: IO (IO ()). I suppose that is unintentional?
There was a problem hiding this comment.
I think, either we need a join or have to consume the action produced at: https://github.com/haskell/haskell-language-server/pull/2434/files#diff-d7140bbfca1b7aaafd8c82d1d6aa21a3f941eb27ba8f08e4d9fb13766b21b418L393
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fourth instalment of #2357