Make heavy use of common sections #2447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
commented
Dec 7, 2021
Comment on lines
-457
to
-460
| -Wall -Wno-name-shadowing -threaded -rtsopts -with-rtsopts=-N -Wno-unticked-promoted-constructors | ||
|
|
||
| if flag(pedantic) | ||
| ghc-options: -Werror -Wredundant-constraints |
There was a problem hiding this comment.
This configuration changes compared to before. E.g. -Wredundant-constraints is always added to the list of warnings.
fendor
commented
Dec 7, 2021
| , directory | ||
| , process | ||
| , hls-test-utils | ||
| , extra | ||
|
|
||
| hs-source-dirs: test/wrapper | ||
| main-is: Main.hs | ||
| ghc-options: -Wall |
There was a problem hiding this comment.
We add more warnings than just -Wall
fendor
force-pushed
the
enhance/more-common-sections-in-hls
branch
from
6ed287e
to
c1539a9
Compare
jneira
approved these changes
Dec 7, 2021
michaelpj
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a minor code-cleanup, unifies warning flags and removes some code repetition.