Ormolu flags #246
Merged
Ormolu flags #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ms_hspp_opts contains the LANGUAGE and OPTIONS pragmas what we want here is the cabal/stack options instead
Because why not?
fendor
reviewed
Jul 27, 2020
| @@ -36,24 +43,24 @@ descriptor plId = (defaultPluginDescriptor plId) | |||
| -- --------------------------------------------------------------------- | |||
|
|
|||
| provider :: FormattingProvider IO | |||
| provider _lf ideState typ contents fp _ = do | |||
| provider lf ideState typ contents fp _ = withIndefiniteProgress lf title Cancellable $ do | |||
There was a problem hiding this comment.
I guess we should have these for all formatting providers?
There was a problem hiding this comment.
In many other plugins too, specially in the Eval plugin
lukel97
reviewed
Jul 27, 2020
|
@pepeiborra Depends on what you mean by "process". |
Does Ormolu use ghc to parse source files? If yes, then ghc will see the language and options pragmas and act accordingly |
|
@pepeiborra In that sense, yes, we use functions from GHC to read pragmas before we run the parser. |
|
So, this is ready for merge, right? |
Closed
pepeiborra
pushed a commit
that referenced
this pull request
Dec 27, 2020
pepeiborra
pushed a commit
that referenced
this pull request
Dec 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's two independent changes here:
Fixes #245