Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable alternate numbers format plugin temporary #2498

Merged
merged 6 commits into from Dec 18, 2021
Merged

Disable alternate numbers format plugin temporary #2498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e1be55e
Disable alternateNumberFormat temporary
jneira Dec 17, 2021
2f38673
Disable alternateNumberFormat tests
jneira Dec 17, 2021
7d99b25
Add a warn in docs
jneira Dec 17, 2021
c4e7a33
Add link to issue in docs
jneira Dec 17, 2021
990c9b4
Merge branch 'master' into disable-alternate-numbers
jneira Dec 18, 2021
fa5aa70
Merge branch 'master' into disable-alternate-numbers
mergify[bot] Dec 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Expand Up @@ -244,7 +244,7 @@ jobs:
name: Test hls-hlint-plugin test suite
run: cabal test hls-hlint-plugin --test-options="$TEST_OPTS" || cabal test hls-hlint-plugin --test-options="$TEST_OPTS" || LSP_TEST_LOG_COLOR=0 LSP_TEST_LOG_MESSAGES=true LSP_TEST_LOG_STDERR=true cabal test hls-hlint-plugin --test-options="$TEST_OPTS"

- if: matrix.test
- if: matrix.test && false
name: Test hls-alternate-number-format-plugin test suite
run: cabal test hls-alternate-number-format-plugin --test-options="$TEST_OPTS" || cabal test hls-alternate-number-format-plugin --test-options="$TEST_OPTS" || LSP_TEST_LOG_COLOR=0 LSP_TEST_LOG_MESSAGES=true LSP_TEST_LOG_STDERR=true cabal test hls-alternate-number-format-plugin --test-options="$TEST_OPTS"

Expand Down
2 changes: 1 addition & 1 deletion docs/features.md
View file
Open in desktop
Expand Up @@ -17,7 +17,7 @@ You can watch demos for some of these features [below](#demos).
- [Module name suggestions](#module-names) for insertion or correction
- [Call hierarchy support](#call-hierarchy)
- [Qualify names from an import declaration](#qualify-imported-names) in your code
- [Suggest alternate numeric formats](#alternate-number-formatting)
- [Suggest alternate numeric formats](#alternate-number-formatting). This plugin is not included by default yet due to a performance issue, see <https://github.com/haskell/haskell-language-server/issues/2490>

## Demos

Expand Down
2 changes: 1 addition & 1 deletion haskell-language-server.cabal
View file
Open in desktop
Expand Up @@ -165,7 +165,7 @@ flag splice

flag alternateNumberFormat
description: Enable Alternate Number Format plugin
default: True
default: False
manual: True

flag qualifyImportedNames
Expand Down