Build with GHC 9.2 #2503

pepeiborra · 2021-12-18T10:38:25Z

Build a GHC 9.2 binary via head.hackage:

cabal update --project-file=cabal-ghc921.project
cabal build --project-file cabal-ghc921.project

Branch is open to contributions - let's crowdsource this.

pepeiborra · 2021-12-18T10:39:25Z

It looks like the Compat layer no longer builds with GHC 9.2:

src/Development/IDE/GHC/Compat/Core.hs:812:3: error:
    Not in scope: ‘TcType.splitForAllTyCoVars’
    Perhaps you meant one of these:
      ‘TcType.tcSplitForAllTyVars’ (imported from GHC.Tc.Utils.TcType),
      ‘GHC.splitForAllTyCoVars’ (imported from GHC)
    Module ‘GHC.Tc.Utils.TcType’ does not export ‘splitForAllTyCoVars’.
    |
812 |   TcType.splitForAllTyCoVars
    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^

There are more errors when I fix this one:

src/Development/IDE/GHC/Compat/Core.hs:75:5: error:
    Not in scope: type constructor or class ‘ModIface’
    Perhaps you meant one of these:
      ‘GHC.ModIface’ (imported from GHC),
      ‘GHC.ModIface_’ (imported from GHC)
    Perhaps you want to add ‘ModIface’ to the import list
    in the import of ‘GHC.Unit.Module.ModIface’
    (src/Development/IDE/GHC/Compat/Core.hs:538:1-57).
   |
75 |     ModIface,
   |     ^^^^^^^^

src/Development/IDE/GHC/Compat/Core.hs:76:5: error:
    Not in scope: type constructor or class ‘ModIface_’
    Perhaps you meant one of these:
      ‘GHC.ModIface_’ (imported from GHC),
      ‘GHC.ModIface’ (imported from GHC)
    Perhaps you want to add ‘ModIface_’ to the import list
    in the import of ‘GHC.Unit.Module.ModIface’
    (src/Development/IDE/GHC/Compat/Core.hs:538:1-57).
   |
76 |     ModIface_(..),
   |     ^^^^^^^^^^^^^

src/Development/IDE/GHC/Compat/Core.hs:100:5: error:
    Not in scope: type constructor or class ‘LexicalFixity’
    Perhaps you meant ‘GHC.LexicalFixity’ (imported from GHC)
    |
100 |     LexicalFixity(..),
    |     ^^^^^^^^^^^^^^^^^

src/Development/IDE/GHC/Compat/Core.hs:102:5: error:
    Not in scope: type constructor or class ‘ModSummary’
    Perhaps you meant ‘GHC.ModSummary’ (imported from GHC)
    |
102 |     ModSummary(..),
    |     ^^^^^^^^^^^^^^

src/Development/IDE/GHC/Compat/Core.hs:124:5: error:
    Not in scope: ‘Development.IDE.GHC.Compat.Core.splitForAllTyCoVars’
    Perhaps you meant one of these:
      ‘Development.IDE.GHC.Compat.Core.tcSplitForAllTyVars’ (line 816),
      ‘Development.IDE.GHC.Compat.Core.mkInfForAllTys’ (line 802),
      ‘Development.IDE.GHC.Compat.Core.dataConExTyCoVars’ (line 781)
    |
124 |     Development.IDE.GHC.Compat.Core.splitForAllTyCoVars,
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

src/Development/IDE/GHC/Compat/Core.hs:150:5: error:
    Not in scope: type constructor or class ‘HsParsedModule’
    Perhaps you meant one of these:
      ‘GHC.HsParsedModule’ (imported from GHC),
      ‘GHC.ParsedModule’ (imported from GHC)
    |
150 |     HsParsedModule(..),
    |     ^^^^^^^^^^^^^^^^^^

src/Development/IDE/GHC/Compat/Core.hs:237:5: error:
    Not in scope: ‘initDynLinker’
    Perhaps you meant ‘initObjLinker’ (imported from GHC.Runtime.Interpreter)
    |
237 |     initDynLinker,
    |     ^^^^^^^^^^^^^

src/Development/IDE/GHC/Compat/Core.hs:252:5: error:
    Not in scope: type constructor or class ‘Target’
    Perhaps you meant one of these:
      ‘GHC.Target’ (imported from GHC),
      ‘GHC.TargetId’ (imported from GHC)
    |
252 |     Target(..),
    |     ^^^^^^^^^^

src/Development/IDE/GHC/Compat/Core.hs:253:5: error:
    Not in scope: type constructor or class ‘TargetId’
    Perhaps you meant one of these:
      ‘GHC.TargetId’ (imported from GHC),
      ‘GHC.Target’ (imported from GHC)
    |
253 |     TargetId(..),
    |     ^^^^^^^^^^^^

src/Development/IDE/GHC/Compat/Core.hs:254:5: error:
    Not in scope: ‘mkModuleGraph’
    Perhaps you meant one of these:
      ‘GHC.mkModuleGraph’ (imported from GHC),
      ‘GHC.getModuleGraph’ (imported from GHC)
    |
254 |     mkModuleGraph,
    |     ^^^^^^^^^^^^^

src/Development/IDE/GHC/Compat/Core.hs:258:5: error:
    Not in scope: type constructor or class ‘InteractiveImport’
    Perhaps you meant ‘GHC.InteractiveImport’ (imported from GHC)
    |
258 |     InteractiveImport(..),
    |     ^^^^^^^^^^^^^^^^^^^^^

src/Development/IDE/GHC/Compat/Core.hs:310:5: error:
    The export item ‘module Language.Haskell.Syntax.Expr’ is not imported
    |
310 |     module Language.Haskell.Syntax.Expr,
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

src/Development/IDE/GHC/Compat/Core.hs:335:5: error:
    Conflicting exports for ‘pprFamInst’:
       ‘module GHC.Core.FamInstEnv’ exports ‘GHC.Core.FamInstEnv.pprFamInst’
         imported from ‘GHC.Core.FamInstEnv’ at src/Development/IDE/GHC/Compat/Core.hs:429:1-36
       ‘module GHC.Types.TyThing.Ppr’ exports ‘GHC.Types.TyThing.Ppr.pprFamInst’
         imported from ‘GHC.Types.TyThing.Ppr’ at src/Development/IDE/GHC/Compat/Core.hs:514:1-38
    |
335 |     module GHC.Types.TyThing.Ppr,
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

src/Development/IDE/GHC/Compat/Core.hs:390:5: error:
    The export item ‘module GHC.Hs’ is not imported
    |
390 |     module GHC.Hs,
    |     ^^^^^^^^^^^^^

/cc @fendor

fendor · 2021-12-18T12:27:43Z

It is easily possible that some imports are incomplete, that was left on the todo list. Not all, but at least most of these imports were added when GHC 9.0 support was added to the plugins. Which was at the very end of my "sprint". However, adding (or hiding appropriately) the imports should suffice for most of these errors. Additionally, iirc, the module GHC.Hs import was added to avoid listing every possible identifier on the export-list, literally just before the MR got merged.

There is at least one big issue left: https://github.com/haskell/haskell-language-server/blob/master/ghcide/src/Development/IDE/GHC/Compat/Outputable.hs#L156
I didn't manage to implement the function mkPrintUnqualifiedDefault with GHC 9.2. mkPrintUnqualified wants a UnitEnv now, and I can't summon it out of the ether. The call-sites of mkPrintUnqualifiedDefault do not allow to trivially get the UnitEnv.

pepeiborra · 2021-12-18T16:57:31Z

If you (or anyone else) is up for helping with this PR, the branch is open to all contributors

…n terms of in-tree annotations)

wz1000 · 2021-12-20T16:45:37Z

My last commit stubs out the getDocumentation function (which re-implements -haddock using exactprint annotations), I've never really been a fan of it anyway. GHC's haddock parsing + stale data should be good enough in the vast majority of cases. I think we should get rid of that function anyway. Thoughts?

pepeiborra · 2021-12-20T17:22:37Z

My last commit stubs out the getDocumentation function (which re-implements -haddock using exactprint annotations), I've never really been a fan of it anyway. GHC's haddock parsing + stale data should be good enough in the vast majority of cases. I think we should get rid of that function anyway. Thoughts?

I'm not a big fan either, but we still use it in a couple of places.
Stubbing it out in 9.2 is fine.
Ideally we would replace all the callsites with getDocumentationTryGhc and delete it.

Anton-Latukha · 2021-12-20T17:40:43Z

Nota bene: As getDocumentation is discussed & GHC-s way is mentioned as preferred - the work on getDocumentationTryGhc & getDocumentationsTryGhc is in #2349 #2371.

The Exactprint module compiles, but code actions are the next focus.

cabal-ghc921.project

Anton-Latukha · 2022-01-09T18:18:11Z

Issues that are left in the thread do not mandate the blockage of the GHC 9.2 support.

Let us go forward.

Since I took part in Ops situations left. When the code merges into the mainline - I would take this thread & open the reports on them.

_{File after the merge:
#2503 (comment)
#2503 (comment)
Already opened:
#2574
#2568}

Also went through the thread & folded some resolved things. So the thread now is more reviewable.

pepeiborra · 2022-01-10T16:37:45Z

The proverbial green light is about to shine. Shall we land this in time for a January HLS Release?

jneira · 2022-01-10T16:40:53Z

yeah, I would include it, maybe with a note about being still experimental?i is it being used on ghc itself by some ghc dev, @wz1000 @mpickering?

mpickering · 2022-01-10T17:34:44Z

yeah, I would include it, maybe with a note about being still experimental?i is it being used on ghc itself by some ghc dev, @wz1000 @mpickering?

I was using an older version of this branch whilst working on a particular GHC branch but not since the testsuite passed. That version had some bugs to do with imports but Zubin said they were due to ghc-exactprint problems which I believe are now fixed.

georgefst · 2022-01-10T18:43:22Z

Shall we land this in time for a January HLS Release?

If we do (which would be great!), it would be nice to make sure #2579 gets merged.

michaelpj · 2022-01-12T17:51:52Z

.github/workflows/test.yml

@@ -146,7 +146,7 @@ jobs:

        run: cabal test wrapper-test --test-options="$TEST_OPTS --rerun-log-file .tasty-rerun-log-wrapper" || cabal test wrapper-test --test-options="$TEST_OPTS  --rerun-log-file .tasty-rerun-log-wrapper" || cabal test wrapper-test --test-options="$TEST_OPTS  --rerun-log-file .tasty-rerun-log-wrapper"

-      - if: matrix.test && matrix.ghc != '9.0.1' && matrix.ghc != '9.2.1'
+      - if: matrix.test && matrix.ghc != '9.2.1'


FYI @jneira I conservatively merged to allow 9.0.1 since we fixed it on master but not allow 9.2.1, but maybe fixing it for 9.0.1 also fixed it for 9.2.1. Not sure, we should try after this is merged perhaps.

michaelpj

If nobody objects, I'll merge this shortly.

pepeiborra added 2 commits December 18, 2021 09:26

WIP

4853ccb

progress

c233569

enable 9.2 in CI

e9327e4

pepeiborra force-pushed the ghc-9.2 branch from 4d577e0 to e9327e4 Compare December 18, 2021 11:11

Merge branch 'master' into ghc-9.2

0e78f03

This comment has been minimized.

Sign in to view

alanz and others added 7 commits December 19, 2021 18:19

Sort out some compatibility issues (#2511)

a1e6af1

fix mkPrintUnqualifiedDefault

a92845a

fix qualified idents

1ea186c

Fix a few more ghc compats

e62a05e

Add new orphans

4d1bc3b

Fix runtime APIs

664ec28

HsParsedModule

f4a6a1b

pepeiborra force-pushed the ghc-9.2 branch from 1a5d64d to f4a6a1b Compare December 20, 2021 00:16

pepeiborra and others added 6 commits December 20, 2021 00:20

export GHC.Hs.Utils

4c84520

9.2 compat for unloading and hie file generation

f6623bc

hlint fix

c024d96

Remove 'setupFinderCache' as its never actually used

b430b94

9.2 compat for Development.IDE.Core.Compile

0a411e2

Stub out 'getDocumentation' on GHC 9.2 (Requires a reimplementation i…

3a834f6

…n terms of in-tree annotations)

Expose binds

a1fd2ea

This comment has been minimized.

Sign in to view

wz1000 and others added 2 commits December 21, 2021 03:29

Remove a bit of CPP by refactoring it into Compat layer

6b9b288

Progress on ghc-exactprint stuff

3fec58d

The Exactprint module compiles, but code actions are the next focus.

do not test class plugin

631bc19

pepeiborra force-pushed the ghc-9.2 branch from 896460f to 631bc19 Compare January 8, 2022 17:04

Anton-Latukha reviewed Jan 8, 2022

View reviewed changes

cabal-ghc921.project Show resolved Hide resolved

pepeiborra added 2 commits January 9, 2022 11:28

Mark hover test broken in Windows and Mac

0d74359

Fix hls-pragmas-plugin test suite

2c4e7eb

This was referenced Jan 9, 2022

Please, CI: align the cabal update to project file #2574

Closed

Please, CI: review the test matrix #2575

Closed

pepeiborra added 2 commits January 9, 2022 23:06

disable testing of refine imports plugin

bfaa86e

disable rename plugin

fb1d5f1

pepeiborra force-pushed the ghc-9.2 branch from 8714f92 to fb1d5f1 Compare January 10, 2022 08:22

pepeiborra added 2 commits January 10, 2022 12:17

Do not test qualify imported names plugin

4c52957

Merge remote-tracking branch 'upstream/master' into ghc-9.2

a4c87a4

georgefst mentioned this pull request Jan 10, 2022

Bump Ormolu and Fourmolu to GHC-9.2-compatible versions #2579

Merged

srid mentioned this pull request Jan 11, 2022

GHC 9.2.1 support Plutonomicon/plutarch-plutus#86

Merged

addressing hlint suggestions

635bd43

michaelpj reviewed Jan 12, 2022

View reviewed changes

michaelpj approved these changes Jan 12, 2022

View reviewed changes

Merge branch 'master' into ghc-9.2

888b613

michaelpj force-pushed the ghc-9.2 branch from d8991a6 to 888b613 Compare January 12, 2022 18:01

Revert hlint change that breaks due to CPP

f6b79f5

michaelpj merged commit 4386396 into master Jan 12, 2022

Anton-Latukha mentioned this pull request Jan 13, 2022

Please, fix CI caching #2584

Closed

Dessix mentioned this pull request Jan 14, 2022

Support for ghc-9.2.* #2179

Closed

32 tasks

mxxun mentioned this pull request Jan 16, 2022

Fix module-name plugin on ghc-9.2.1 #2594

Merged

L-as mentioned this pull request Jan 17, 2022

Get HLS working again Plutonomicon/plutarch-plutus#117

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build with GHC 9.2 #2503

Build with GHC 9.2 #2503

pepeiborra commented Dec 18, 2021 •

edited by Anton-Latukha

pepeiborra commented Dec 18, 2021 •

edited

fendor commented Dec 18, 2021 •

edited

pepeiborra commented Dec 18, 2021

This comment has been minimized.

wz1000 commented Dec 20, 2021

pepeiborra commented Dec 20, 2021

Anton-Latukha commented Dec 20, 2021 •

edited

This comment has been minimized.

Anton-Latukha commented Jan 9, 2022 •

edited

pepeiborra commented Jan 10, 2022

jneira commented Jan 10, 2022 •

edited

mpickering commented Jan 10, 2022

georgefst commented Jan 10, 2022

michaelpj Jan 12, 2022

michaelpj left a comment

Build with GHC 9.2 #2503

Build with GHC 9.2 #2503

Conversation

pepeiborra commented Dec 18, 2021 • edited by Anton-Latukha

Branch is open to contributions - let's crowdsource this.

pepeiborra commented Dec 18, 2021 • edited

fendor commented Dec 18, 2021 • edited

pepeiborra commented Dec 18, 2021

This comment has been minimized.

wz1000 commented Dec 20, 2021

pepeiborra commented Dec 20, 2021

Anton-Latukha commented Dec 20, 2021 • edited

This comment has been minimized.

Anton-Latukha commented Jan 9, 2022 • edited

pepeiborra commented Jan 10, 2022

jneira commented Jan 10, 2022 • edited

mpickering commented Jan 10, 2022

georgefst commented Jan 10, 2022

michaelpj Jan 12, 2022

Choose a reason for hiding this comment

michaelpj left a comment

Choose a reason for hiding this comment

pepeiborra commented Dec 18, 2021 •

edited by Anton-Latukha

pepeiborra commented Dec 18, 2021 •

edited

fendor commented Dec 18, 2021 •

edited

Anton-Latukha commented Dec 20, 2021 •

edited

Anton-Latukha commented Jan 9, 2022 •

edited

jneira commented Jan 10, 2022 •

edited